thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
casted
ClickHouse/cmake/cxx.cmake

26 lines
1.4 KiB
CMake
Raw Permalink Normal View History

(Re)-enable libcxx debug mode - We previously compiled libcxx with _LIBCPP_DEBUG=0. In old libcxx versions, this (surprisingly) enabled the basic debug mode [1]. - In libcxx 15 (the version we are currently using), _LIBCPP_DEBUG=0 does nothing [2], the replacement is _LIBCPP_ENABLE_DEBUG_MODE=1. - The debug mode is only enabled in Debug builds. Their docs say the extra check change complexity guarantees + the asserts crash which we don't want in Release builds. The debug mode detects issues like in [3]. Crashes look like this (for example) ``` /data/ch/contrib/llvm-project/libcxx/include/__iterator/wrap_iter.h:99: assertion ::std::__libcpp_is_constant_evaluated() || (__get_const_db()->__dereferenceable(this)) failed: Attempted to increment a non-incrementable iteratorAborted (core dumped) ``` - I had to mute some new clang-tidy warnings in places that deal with container iterators. They got heavier and copy-by-value now yields a warning, e.g. for (auto it : iterators) /// <-- warning [...] [1] https://releases.llvm.org/12.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html [2] https://releases.llvm.org/15.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html [3] https://github.com/llvm/llvm-project/blob/main/libcxx/test/support/container_debug_tests.h
2024-09-30 16:58:33 +00:00
if (CMAKE_BUILD_TYPE_UC STREQUAL "DEBUG")
... re-enable only the assertions (not full debug mode)
2024-10-15 21:07:07 +00:00
# Enable libcxx debug mode: https://releases.llvm.org/15.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html
(Re)-enable libcxx debug mode - We previously compiled libcxx with _LIBCPP_DEBUG=0. In old libcxx versions, this (surprisingly) enabled the basic debug mode [1]. - In libcxx 15 (the version we are currently using), _LIBCPP_DEBUG=0 does nothing [2], the replacement is _LIBCPP_ENABLE_DEBUG_MODE=1. - The debug mode is only enabled in Debug builds. Their docs say the extra check change complexity guarantees + the asserts crash which we don't want in Release builds. The debug mode detects issues like in [3]. Crashes look like this (for example) ``` /data/ch/contrib/llvm-project/libcxx/include/__iterator/wrap_iter.h:99: assertion ::std::__libcpp_is_constant_evaluated() || (__get_const_db()->__dereferenceable(this)) failed: Attempted to increment a non-incrementable iteratorAborted (core dumped) ``` - I had to mute some new clang-tidy warnings in places that deal with container iterators. They got heavier and copy-by-value now yields a warning, e.g. for (auto it : iterators) /// <-- warning [...] [1] https://releases.llvm.org/12.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html [2] https://releases.llvm.org/15.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html [3] https://github.com/llvm/llvm-project/blob/main/libcxx/test/support/container_debug_tests.h
2024-09-30 16:58:33 +00:00
# The docs say the debug mode violates complexity guarantees, so do this only for Debug builds.
... re-enable only the assertions (not full debug mode)
2024-10-15 21:07:07 +00:00
# set (CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -D_LIBCPP_ENABLE_DEBUG_MODE=1")
# ^^ Crashes the database upon startup, needs investigation.
# Besides that, the implementation looks like a poor man's MSAN specific to libcxx. Since CI tests MSAN
# anyways, we can keep the debug mode disabled.
(Re)-enable libcxx debug mode - We previously compiled libcxx with _LIBCPP_DEBUG=0. In old libcxx versions, this (surprisingly) enabled the basic debug mode [1]. - In libcxx 15 (the version we are currently using), _LIBCPP_DEBUG=0 does nothing [2], the replacement is _LIBCPP_ENABLE_DEBUG_MODE=1. - The debug mode is only enabled in Debug builds. Their docs say the extra check change complexity guarantees + the asserts crash which we don't want in Release builds. The debug mode detects issues like in [3]. Crashes look like this (for example) ``` /data/ch/contrib/llvm-project/libcxx/include/__iterator/wrap_iter.h:99: assertion ::std::__libcpp_is_constant_evaluated() || (__get_const_db()->__dereferenceable(this)) failed: Attempted to increment a non-incrementable iteratorAborted (core dumped) ``` - I had to mute some new clang-tidy warnings in places that deal with container iterators. They got heavier and copy-by-value now yields a warning, e.g. for (auto it : iterators) /// <-- warning [...] [1] https://releases.llvm.org/12.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html [2] https://releases.llvm.org/15.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html [3] https://github.com/llvm/llvm-project/blob/main/libcxx/test/support/container_debug_tests.h
2024-09-30 16:58:33 +00:00
... re-enable only the assertions (not full debug mode)
2024-10-15 21:07:07 +00:00
# Libcxx also provides extra assertions:
(Re)-enable libcxx debug mode - We previously compiled libcxx with _LIBCPP_DEBUG=0. In old libcxx versions, this (surprisingly) enabled the basic debug mode [1]. - In libcxx 15 (the version we are currently using), _LIBCPP_DEBUG=0 does nothing [2], the replacement is _LIBCPP_ENABLE_DEBUG_MODE=1. - The debug mode is only enabled in Debug builds. Their docs say the extra check change complexity guarantees + the asserts crash which we don't want in Release builds. The debug mode detects issues like in [3]. Crashes look like this (for example) ``` /data/ch/contrib/llvm-project/libcxx/include/__iterator/wrap_iter.h:99: assertion ::std::__libcpp_is_constant_evaluated() || (__get_const_db()->__dereferenceable(this)) failed: Attempted to increment a non-incrementable iteratorAborted (core dumped) ``` - I had to mute some new clang-tidy warnings in places that deal with container iterators. They got heavier and copy-by-value now yields a warning, e.g. for (auto it : iterators) /// <-- warning [...] [1] https://releases.llvm.org/12.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html [2] https://releases.llvm.org/15.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html [3] https://github.com/llvm/llvm-project/blob/main/libcxx/test/support/container_debug_tests.h
2024-09-30 16:58:33 +00:00
# --> https://releases.llvm.org/15.0.0/projects/libcxx/docs/UsingLibcxx.html#assertions-mode
... re-enable only the assertions (not full debug mode)
2024-10-15 21:07:07 +00:00
# These look orthogonal to the debug mode but the debug mode enables them implicitly:
(Re)-enable libcxx debug mode - We previously compiled libcxx with _LIBCPP_DEBUG=0. In old libcxx versions, this (surprisingly) enabled the basic debug mode [1]. - In libcxx 15 (the version we are currently using), _LIBCPP_DEBUG=0 does nothing [2], the replacement is _LIBCPP_ENABLE_DEBUG_MODE=1. - The debug mode is only enabled in Debug builds. Their docs say the extra check change complexity guarantees + the asserts crash which we don't want in Release builds. The debug mode detects issues like in [3]. Crashes look like this (for example) ``` /data/ch/contrib/llvm-project/libcxx/include/__iterator/wrap_iter.h:99: assertion ::std::__libcpp_is_constant_evaluated() || (__get_const_db()->__dereferenceable(this)) failed: Attempted to increment a non-incrementable iteratorAborted (core dumped) ``` - I had to mute some new clang-tidy warnings in places that deal with container iterators. They got heavier and copy-by-value now yields a warning, e.g. for (auto it : iterators) /// <-- warning [...] [1] https://releases.llvm.org/12.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html [2] https://releases.llvm.org/15.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html [3] https://github.com/llvm/llvm-project/blob/main/libcxx/test/support/container_debug_tests.h
2024-09-30 16:58:33 +00:00
# --> https://github.com/llvm/llvm-project/blob/release/15.x/libcxx/include/__assert#L29
... re-enable only the assertions (not full debug mode)
2024-10-15 21:07:07 +00:00
# They are cheap and straightforward, so enable them in debug builds:
set (CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -D_LIBCPP_ENABLE_ASSERTIONS=1")
(Re)-enable libcxx debug mode - We previously compiled libcxx with _LIBCPP_DEBUG=0. In old libcxx versions, this (surprisingly) enabled the basic debug mode [1]. - In libcxx 15 (the version we are currently using), _LIBCPP_DEBUG=0 does nothing [2], the replacement is _LIBCPP_ENABLE_DEBUG_MODE=1. - The debug mode is only enabled in Debug builds. Their docs say the extra check change complexity guarantees + the asserts crash which we don't want in Release builds. The debug mode detects issues like in [3]. Crashes look like this (for example) ``` /data/ch/contrib/llvm-project/libcxx/include/__iterator/wrap_iter.h:99: assertion ::std::__libcpp_is_constant_evaluated() || (__get_const_db()->__dereferenceable(this)) failed: Attempted to increment a non-incrementable iteratorAborted (core dumped) ``` - I had to mute some new clang-tidy warnings in places that deal with container iterators. They got heavier and copy-by-value now yields a warning, e.g. for (auto it : iterators) /// <-- warning [...] [1] https://releases.llvm.org/12.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html [2] https://releases.llvm.org/15.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html [3] https://github.com/llvm/llvm-project/blob/main/libcxx/test/support/container_debug_tests.h
2024-09-30 16:58:33 +00:00
# TODO Once we upgrade to LLVM 18+, reconsider all of the above as they introduced "hardening modes":
# https://libcxx.llvm.org/Hardening.html
endif ()
Revert "Revert "cmake: Add option to fail configuration instead of auto-reconfiguration"" This reverts commit 89419ceb9bd60121a029430b26aa4506c517f01d (curl part moved to separate commit) Squashed: - termcap removed - fix for cassandra on apple merged - cmake: fix "Can't find system zlib library" in unbundled build - cmake: fix condition when testing for rdkafka platform - cmake: PROTOBUF_OLD_ABI_COMPAT shouldn't be enabled for internal protobuf Signed-off-by: Konstantin Podshumok <kpp.live+signed@gmail.com>
2020-08-14 15:44:04 +00:00
cmake: do not allow internal libstdc++ usage Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-20 14:45:42 +00:00
add_subdirectory(contrib/libcxxabi-cmake)
add_subdirectory(contrib/libcxx-cmake)
Revert "Revert "cmake: Add option to fail configuration instead of auto-reconfiguration"" This reverts commit 89419ceb9bd60121a029430b26aa4506c517f01d (curl part moved to separate commit) Squashed: - termcap removed - fix for cassandra on apple merged - cmake: fix "Can't find system zlib library" in unbundled build - cmake: fix condition when testing for rdkafka platform - cmake: PROTOBUF_OLD_ABI_COMPAT shouldn't be enabled for internal protobuf Signed-off-by: Konstantin Podshumok <kpp.live+signed@gmail.com>
2020-08-14 15:44:04 +00:00
cmake: do not allow internal libstdc++ usage Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-20 14:45:42 +00:00
# Exception handling library is embedded into libcxxabi.
Make a better build scheme (#6500) * Fix shared build * Major default libs refactor * Fix build with gcc_eh * Link all libraries as a big group. * Use global interface library as a group * Build capnproto using our cmake * Use only internal libunwind
2019-08-28 20:49:37 +00:00
cmake: do not allow internal libstdc++ usage Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-20 14:45:42 +00:00
target_link_libraries(global-libs INTERFACE cxx cxxabi)
Reference in New Issue Copy Permalink