thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
212aef3dc2
ClickHouse/.clang-tidy

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

182 lines
6.4 KiB
Plaintext
Raw Normal View History

Enable clang-tidy for headers clang-tidy now also checks code in header files. Because the analyzer finds tons of issues, activate the check only for directory "base/" (see file ".clang-tidy"). All other directories, in particular "src/" are left to future work. While many findings were fixed, some were not (and suppressed instead). Reasons for this include: a) the file is 1:1 copypaste of a 3rd-party lib (e.g. pcg_extras.h) and fixing stuff would make upgrades/fixes more difficult b) a fix would have broken lots of using code
2022-08-26 13:54:57 +00:00
# To run clang-tidy from CMake, build ClickHouse with -DENABLE_CLANG_TIDY=1. To show all warnings, it is
# recommended to pass "-k0" to Ninja.
Function name normalization fix functions header
2022-10-04 15:29:33 +00:00
# Enable all checks + disable selected checks. Feel free to remove disabled checks from below list if
Add a comment about disabling further checks
2022-05-19 15:39:53 +00:00
# a) the new check is not controversial (this includes many checks in readability-* and google-*) or
# b) too noisy (checks with > 100 new warnings are considered noisy, this includes e.g. cppcoreguidelines-*).
Enable clang-tidy for headers clang-tidy now also checks code in header files. Because the analyzer finds tons of issues, activate the check only for directory "base/" (see file ".clang-tidy"). All other directories, in particular "src/" are left to future work. While many findings were fixed, some were not (and suppressed instead). Reasons for this include: a) the file is 1:1 copypaste of a 3rd-party lib (e.g. pcg_extras.h) and fixing stuff would make upgrades/fixes more difficult b) a fix would have broken lots of using code
2022-08-26 13:54:57 +00:00
# TODO Let clang-tidy check headers in further directories
# --> HeaderFilterRegex: '^.*/(src|base|programs|utils)/.*(h|hpp)$'
HeaderFilterRegex: '^.*/(base)/.*(h|hpp)$'
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
Checks: '*,
-abseil-*,
-altera-*,
-android-*,
Sort checks
2022-12-02 09:17:05 +00:00
-bugprone-assignment-in-if-condition,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-bugprone-branch-clone,
-bugprone-easily-swappable-parameters,
-bugprone-exception-escape,
-bugprone-implicit-widening-of-multiplication-result,
-bugprone-narrowing-conversions,
-bugprone-not-null-terminated-result,
Small-ish .clang-tidy update
2023-05-13 15:29:45 +00:00
-bugprone-reserved-identifier, # useful but too slow, TODO retry when https://reviews.llvm.org/rG1c282052624f9d0bd273bde0b47b30c96699c6c7 is merged
Fix clang-tidy warnings (from clang-15) Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-10 07:58:49 +00:00
-bugprone-unchecked-optional-access,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
Fixup clang-tidy
2022-05-05 07:50:57 +00:00
-cert-dcl16-c,
Address clang-tidy slowness
2023-03-14 22:24:20 +00:00
-cert-dcl37-c,
-cert-dcl51-cpp,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-cert-err58-cpp,
Fixup clang-tidy
2022-05-05 07:50:57 +00:00
-cert-msc32-c,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-cert-msc51-cpp,
-cert-oop54-cpp,
-cert-oop57-cpp,
Further fixup of Linux-specific failures
2022-05-05 10:44:08 +00:00
-clang-analyzer-optin.performance.Padding,
Fixup clang-tidy
2022-05-05 07:50:57 +00:00
-clang-analyzer-optin.portability.UnixAPI,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-clang-analyzer-security.insecureAPI.bzero,
-clang-analyzer-security.insecureAPI.strcpy,
A few clangtidy updates Enable: - bugprone-lambda-function-name: "Checks for attempts to get the name of a function from within a lambda expression. The name of a lambda is always something like operator(), which is almost never what was intended." - bugprone-unhandled-self-assignment: "Finds user-defined copy assignment operators which do not protect the code against self-assignment either by checking self-assignment explicitly or using the copy-and-swap or the copy-and-move method."" - hicpp-invalid-access-moved: "Warns if an object is used after it has been moved." - hicpp-use-noexcept: "This check replaces deprecated dynamic exception specifications with the appropriate noexcept specification (introduced in C++11)" - hicpp-use-override: "Adds override (introduced in C++11) to overridden virtual functions and removes virtual from those functions as it is not required." - performance-type-promotion-in-math-fn: "Finds calls to C math library functions (from math.h or, in C++, cmath) with implicit float to double promotions." Split up: - cppcoreguidelines-*. Some of them may be useful (haven't checked in detail), therefore allow to toggle them individually. Disable: - linuxkernel-*. Obvious.
2022-05-16 15:44:19 +00:00
-cppcoreguidelines-avoid-c-arrays,
Preparation for libcxx(abi), llvm, clang-tidy 16
2023-03-19 16:23:46 +00:00
-cppcoreguidelines-avoid-const-or-ref-data-members,
-cppcoreguidelines-avoid-do-while,
A few clangtidy updates Enable: - bugprone-lambda-function-name: "Checks for attempts to get the name of a function from within a lambda expression. The name of a lambda is always something like operator(), which is almost never what was intended." - bugprone-unhandled-self-assignment: "Finds user-defined copy assignment operators which do not protect the code against self-assignment either by checking self-assignment explicitly or using the copy-and-swap or the copy-and-move method."" - hicpp-invalid-access-moved: "Warns if an object is used after it has been moved." - hicpp-use-noexcept: "This check replaces deprecated dynamic exception specifications with the appropriate noexcept specification (introduced in C++11)" - hicpp-use-override: "Adds override (introduced in C++11) to overridden virtual functions and removes virtual from those functions as it is not required." - performance-type-promotion-in-math-fn: "Finds calls to C math library functions (from math.h or, in C++, cmath) with implicit float to double promotions." Split up: - cppcoreguidelines-*. Some of them may be useful (haven't checked in detail), therefore allow to toggle them individually. Disable: - linuxkernel-*. Obvious.
2022-05-16 15:44:19 +00:00
-cppcoreguidelines-avoid-goto,
-cppcoreguidelines-avoid-magic-numbers,
-cppcoreguidelines-avoid-non-const-global-variables,
-cppcoreguidelines-explicit-virtual-functions,
-cppcoreguidelines-init-variables,
-cppcoreguidelines-interfaces-global-init,
-cppcoreguidelines-macro-usage,
-cppcoreguidelines-narrowing-conversions,
-cppcoreguidelines-no-malloc,
-cppcoreguidelines-non-private-member-variables-in-classes,
-cppcoreguidelines-owning-memory,
-cppcoreguidelines-prefer-member-initializer,
-cppcoreguidelines-pro-bounds-array-to-pointer-decay,
-cppcoreguidelines-pro-bounds-constant-array-index,
-cppcoreguidelines-pro-bounds-pointer-arithmetic,
-cppcoreguidelines-pro-type-const-cast,
-cppcoreguidelines-pro-type-cstyle-cast,
-cppcoreguidelines-pro-type-member-init,
-cppcoreguidelines-pro-type-reinterpret-cast,
-cppcoreguidelines-pro-type-static-cast-downcast,
-cppcoreguidelines-pro-type-union-access,
-cppcoreguidelines-pro-type-vararg,
-cppcoreguidelines-slicing,
-cppcoreguidelines-special-member-functions,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-darwin-*,
-fuchsia-*,
-google-build-using-namespace,
-google-readability-braces-around-statements,
Merge branch 'master' into llvm-14
2022-05-16 10:03:26 +00:00
-google-readability-casting,
Fixup clang-tidy
2022-05-05 07:50:57 +00:00
-google-readability-function-size,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-google-readability-namespace-comments,
-google-readability-todo,
-google-upgrade-googletest-case,
-hicpp-avoid-c-arrays,
-hicpp-avoid-goto,
-hicpp-braces-around-statements,
Fixup clang-tidy
2022-05-05 07:50:57 +00:00
-hicpp-explicit-conversions,
-hicpp-function-size,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-hicpp-member-init,
-hicpp-move-const-arg,
-hicpp-multiway-paths-covered,
-hicpp-named-parameter,
-hicpp-no-array-decay,
-hicpp-no-assembler,
-hicpp-no-malloc,
-hicpp-signed-bitwise,
-hicpp-special-member-functions,
-hicpp-uppercase-literal-suffix,
-hicpp-use-auto,
-hicpp-use-emplace,
-hicpp-vararg,
A few clangtidy updates Enable: - bugprone-lambda-function-name: "Checks for attempts to get the name of a function from within a lambda expression. The name of a lambda is always something like operator(), which is almost never what was intended." - bugprone-unhandled-self-assignment: "Finds user-defined copy assignment operators which do not protect the code against self-assignment either by checking self-assignment explicitly or using the copy-and-swap or the copy-and-move method."" - hicpp-invalid-access-moved: "Warns if an object is used after it has been moved." - hicpp-use-noexcept: "This check replaces deprecated dynamic exception specifications with the appropriate noexcept specification (introduced in C++11)" - hicpp-use-override: "Adds override (introduced in C++11) to overridden virtual functions and removes virtual from those functions as it is not required." - performance-type-promotion-in-math-fn: "Finds calls to C math library functions (from math.h or, in C++, cmath) with implicit float to double promotions." Split up: - cppcoreguidelines-*. Some of them may be useful (haven't checked in detail), therefore allow to toggle them individually. Disable: - linuxkernel-*. Obvious.
2022-05-16 15:44:19 +00:00
-linuxkernel-*,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-llvm-*,
-llvmlibc-*,
-openmp-*,
Sort checks
2022-12-02 09:17:05 +00:00
-misc-const-correctness,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-misc-no-recursion,
-misc-non-private-member-variables-in-classes,
Cleanup mess in .clang-tidy This fixes some mess I left in .clang-tidy (#43863) when clang-tidy build times were too bad and had to be reduced urgently. Verified locally that runtime isn't affected by this PR.
2023-04-04 16:00:32 +00:00
-misc-confusable-identifiers, # useful but slooow
Disable misc-use-anonymous-namespace check in clang-tidy It is too noisy during upgrade: $ grep error: build_log.log | awk '{print $NF}' | sort | uniq -c 1 [bugprone-standalone-empty,-warnings-as-errors] 1 [misc-misplaced-const,-warnings-as-errors] 2147 [misc-use-anonymous-namespace,-warnings-as-errors] 6 [modernize-loop-convert,-warnings-as-errors] 9 [readability-redundant-string-cstr,-warnings-as-errors] Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 18:43:52 +00:00
-misc-use-anonymous-namespace,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-modernize-avoid-c-arrays,
-modernize-concat-nested-namespaces,
Sort checks
2022-12-02 09:17:05 +00:00
-modernize-macro-to-enum,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-modernize-pass-by-value,
-modernize-return-braced-init-list,
-modernize-use-auto,
-modernize-use-default-member-init,
-modernize-use-emplace,
-modernize-use-nodiscard,
-modernize-use-override,
-modernize-use-trailing-return-type,
-performance-inefficient-string-concatenation,
-performance-no-int-to-ptr,
-performance-unnecessary-value-param,
Further fixup of Linux-specific failures
2022-05-05 10:44:08 +00:00
-portability-simd-intrinsics,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-readability-braces-around-statements,
Preparation for libcxx(abi), llvm, clang-tidy 16
2023-03-19 16:23:46 +00:00
-readability-convert-member-functions-to-static,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-readability-else-after-return,
-readability-function-cognitive-complexity,
-readability-function-size,
Update .clang-tidy
2022-05-16 14:20:23 +00:00
-readability-identifier-length,
Small-ish .clang-tidy update
2023-05-13 15:29:45 +00:00
-readability-identifier-naming, # useful but too slow
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-readability-implicit-bool-conversion,
-readability-isolate-declaration,
-readability-magic-numbers,
-readability-named-parameter,
-readability-redundant-declaration,
Sort checks
2022-12-02 09:17:05 +00:00
-readability-simplify-boolean-expr,
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
-readability-static-accessed-through-instance,
-readability-suspicious-call-argument,
-readability-uppercase-literal-suffix,
-readability-use-anyofallof,
-zirkon-*,
clang-tidy, part 2
2020-03-18 00:57:00 +00:00
'
Invert .clang-tidy Instead of disabling all checks + specifying which are enabled (whitelist), enable all checks + specify which checks are disabled (blacklist). The same set of checks executes as before. Motivation: a) Given the goal to (generally) enable as many checks as possible, a blacklist produces a smaller and easier to maintain .clang-tidy file. b) Many new checks introduced with LLVM 12/13/14 were forgotten to turn on. A blacklist makes sure that future compiler upgrades enable new checks by default.
2022-05-04 17:24:02 +00:00
Added some clang-tidy checks
2020-03-08 20:17:49 +00:00
WarningsAsErrors: '*'
Clang Tidy, part 7 (#9799) * Attempt to enable identifier naming check * Attempt to enable identifier naming check, continue * Progress on identifier names * Adopt identifier names check * Fixed error * Merge with master * Fixed build * Fixed build * Fixed build * Fixed build * Fixed build * Fixed error * Fixed error * Fixed error
2020-03-23 02:12:31 +00:00
CheckOptions:
Fix minor glitch
2023-03-16 16:59:24 +00:00
readability-identifier-naming.ClassCase: CamelCase
clang-tidy >= 15: write CheckOptions in dictionary format ".clang-tidy files can now use the more natural dictionary syntax for specifying CheckOptions.", [0] [0] https://releases.llvm.org/15.0.0/tools/clang/tools/extra/docs/ReleaseNotes.html#improvements-to-clang-tidy
2023-03-16 13:49:27 +00:00
readability-identifier-naming.EnumCase: CamelCase
readability-identifier-naming.LocalVariableCase: lower_case
readability-identifier-naming.StaticConstantCase: aNy_CasE
readability-identifier-naming.MemberCase: lower_case
readability-identifier-naming.PrivateMemberPrefix: ''
readability-identifier-naming.ProtectedMemberPrefix: ''
readability-identifier-naming.PublicMemberCase: lower_case
readability-identifier-naming.MethodCase: camelBack
readability-identifier-naming.PrivateMethodPrefix: ''
readability-identifier-naming.ProtectedMethodPrefix: ''
readability-identifier-naming.ParameterPackCase: lower_case
readability-identifier-naming.StructCase: CamelCase
readability-identifier-naming.TemplateTemplateParameterCase: CamelCase
readability-identifier-naming.TemplateUsingCase: lower_case
readability-identifier-naming.TypeTemplateParameterCase: CamelCase
readability-identifier-naming.TypedefCase: CamelCase
readability-identifier-naming.UnionCase: CamelCase
readability-identifier-naming.UsingCase: CamelCase
modernize-loop-convert.UseCxx20ReverseRanges: false
performance-move-const-arg.CheckTriviallyCopyableMove: false
# Workaround clang-tidy bug: https://github.com/llvm/llvm-project/issues/46097
readability-identifier-naming.TypeTemplateParameterIgnoredRegexp: expr-type
cppcoreguidelines-avoid-do-while.IgnoreMacros: true
Reference in New Issue Copy Permalink