thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-12 09:22:05 +00:00
Code Issues Packages Projects Releases Wiki Activity
330212e0f4
ClickHouse/src/Storages/System/StorageSystemTimeZones.h

27 lines
670 B
C++
Raw Normal View History

add time_zones tables This table adds a new table called the `time_zones` table: ``` :) select * from system.time_zones limit 10; SELECT * FROM system.time_zones LIMIT 10 ┌─time_zone──────────┐ │ Africa/Abidjan │ │ Africa/Accra │ │ Africa/Addis_Ababa │ │ Africa/Algiers │ │ Africa/Asmara │ │ Africa/Asmera │ │ Africa/Bamako │ │ Africa/Bangui │ │ Africa/Banjul │ │ Africa/Bissau │ └────────────────────┘ 10 rows in set. Elapsed: 0.012 sec. ``` The available timezones are parsed from under `ClickHouse/contrib/cctz/testdata/zoneinfo` through a script and the table content is constructed from the StorageSystemTimeZones.generated.cpp`. I was able to test this locally and was able to get a list of time zones as shown above.
2020-08-19 08:34:03 +00:00
#pragma once
Remove inherited create() method + disallow copying The original motivation for this commit was that shared_ptr_helper used std::shared_ptr<>() which does two heap allocations instead of make_shared<>() which does a single allocation. Turned out that 1. the affected code (--> Storages/) is not on a hot path (rendering the performance argument moot ...) 2. yet copying Storage objects is potentially dangerous and was previously allowed. Hence, this change - removes shared_ptr_helper and as a result all inherited create() methods, - instead, Storage objects are now created using make_shared<>() by the caller (for that to work, many constructors had to be made public), and - all Storage classes were marked as noncopyable using boost::noncopyable. In sum, we are (likely) not making things faster but the code becomes cleaner and harder to misuse.
2022-04-19 20:47:29 +00:00
#include <boost/noncopyable.hpp>
try and fix gcc-9 build. This tries to fix the failing gcc-9 unbundled build: https://clickhouse-builds.s3.yandex.net/13880/e437d85b927a47da69b8bdc4dde95917c2261cbe/clickhouse_build_check/build_log_753740668_1598037713.txt
2020-08-22 17:52:35 +00:00
#include <Storages/System/IStorageSystemOneBlock.h>
add time_zones tables This table adds a new table called the `time_zones` table: ``` :) select * from system.time_zones limit 10; SELECT * FROM system.time_zones LIMIT 10 ┌─time_zone──────────┐ │ Africa/Abidjan │ │ Africa/Accra │ │ Africa/Addis_Ababa │ │ Africa/Algiers │ │ Africa/Asmara │ │ Africa/Asmera │ │ Africa/Bamako │ │ Africa/Bangui │ │ Africa/Banjul │ │ Africa/Bissau │ └────────────────────┘ 10 rows in set. Elapsed: 0.012 sec. ``` The available timezones are parsed from under `ClickHouse/contrib/cctz/testdata/zoneinfo` through a script and the table content is constructed from the StorageSystemTimeZones.generated.cpp`. I was able to test this locally and was able to get a list of time zones as shown above.
2020-08-19 08:34:03 +00:00
namespace DB
{
class Context;
/** System table "time_zones" with list of timezones pulled from /contrib/cctz/testdata/zoneinfo
*/
Remove inherited create() method + disallow copying The original motivation for this commit was that shared_ptr_helper used std::shared_ptr<>() which does two heap allocations instead of make_shared<>() which does a single allocation. Turned out that 1. the affected code (--> Storages/) is not on a hot path (rendering the performance argument moot ...) 2. yet copying Storage objects is potentially dangerous and was previously allowed. Hence, this change - removes shared_ptr_helper and as a result all inherited create() methods, - instead, Storage objects are now created using make_shared<>() by the caller (for that to work, many constructors had to be made public), and - all Storage classes were marked as noncopyable using boost::noncopyable. In sum, we are (likely) not making things faster but the code becomes cleaner and harder to misuse.
2022-04-19 20:47:29 +00:00
class StorageSystemTimeZones final : public IStorageSystemOneBlock<StorageSystemTimeZones>, boost::noncopyable
add time_zones tables This table adds a new table called the `time_zones` table: ``` :) select * from system.time_zones limit 10; SELECT * FROM system.time_zones LIMIT 10 ┌─time_zone──────────┐ │ Africa/Abidjan │ │ Africa/Accra │ │ Africa/Addis_Ababa │ │ Africa/Algiers │ │ Africa/Asmara │ │ Africa/Asmera │ │ Africa/Bamako │ │ Africa/Bangui │ │ Africa/Banjul │ │ Africa/Bissau │ └────────────────────┘ 10 rows in set. Elapsed: 0.012 sec. ``` The available timezones are parsed from under `ClickHouse/contrib/cctz/testdata/zoneinfo` through a script and the table content is constructed from the StorageSystemTimeZones.generated.cpp`. I was able to test this locally and was able to get a list of time zones as shown above.
2020-08-19 08:34:03 +00:00
{
Remove inherited create() method + disallow copying The original motivation for this commit was that shared_ptr_helper used std::shared_ptr<>() which does two heap allocations instead of make_shared<>() which does a single allocation. Turned out that 1. the affected code (--> Storages/) is not on a hot path (rendering the performance argument moot ...) 2. yet copying Storage objects is potentially dangerous and was previously allowed. Hence, this change - removes shared_ptr_helper and as a result all inherited create() methods, - instead, Storage objects are now created using make_shared<>() by the caller (for that to work, many constructors had to be made public), and - all Storage classes were marked as noncopyable using boost::noncopyable. In sum, we are (likely) not making things faster but the code becomes cleaner and harder to misuse.
2022-04-19 20:47:29 +00:00
public:
Replace all Context references with std::weak_ptr (#22297) * Replace all Context references with std::weak_ptr * Fix shared context captured by value * Fix build * Fix Context with named sessions * Fix copy context * Fix gcc build * Merge with master and fix build * Fix gcc-9 build
2021-04-10 23:33:54 +00:00
void fillData(MutableColumns & res_columns, ContextPtr context, const SelectQueryInfo & query_info) const override;
add time_zones tables This table adds a new table called the `time_zones` table: ``` :) select * from system.time_zones limit 10; SELECT * FROM system.time_zones LIMIT 10 ┌─time_zone──────────┐ │ Africa/Abidjan │ │ Africa/Accra │ │ Africa/Addis_Ababa │ │ Africa/Algiers │ │ Africa/Asmara │ │ Africa/Asmera │ │ Africa/Bamako │ │ Africa/Bangui │ │ Africa/Banjul │ │ Africa/Bissau │ └────────────────────┘ 10 rows in set. Elapsed: 0.012 sec. ``` The available timezones are parsed from under `ClickHouse/contrib/cctz/testdata/zoneinfo` through a script and the table content is constructed from the StorageSystemTimeZones.generated.cpp`. I was able to test this locally and was able to get a list of time zones as shown above.
2020-08-19 08:34:03 +00:00
using IStorageSystemOneBlock::IStorageSystemOneBlock;
public:
std::string getName() const override { return "SystemTimeZones"; }
static NamesAndTypesList getNamesAndTypes();
};
}
Reference in New Issue Copy Permalink