ClickHouse/tests/ci/run_check.py

298 lines
9.9 KiB
Python
Raw Normal View History

2021-09-15 12:59:39 +00:00
#!/usr/bin/env python3
import sys
2021-09-15 13:04:29 +00:00
import logging
2022-01-13 11:08:31 +00:00
import re
from typing import Tuple
2021-11-26 14:00:09 +00:00
from github import Github
from env_helper import GITHUB_RUN_URL, GITHUB_REPOSITORY, GITHUB_SERVER_URL
2021-11-26 14:00:09 +00:00
from pr_info import PRInfo
from get_robot_token import get_best_robot_token
2022-03-29 17:50:06 +00:00
from commit_status_helper import get_commit, post_labels, remove_labels
2021-09-15 12:59:39 +00:00
2022-01-13 11:06:50 +00:00
NAME = "Run Check (actions)"
2021-09-15 12:59:39 +00:00
TRUSTED_ORG_IDS = {
2022-01-13 11:06:50 +00:00
7409213, # yandex
2021-09-15 12:59:39 +00:00
28471076, # altinity
54801242, # clickhouse
}
2022-02-05 17:26:43 +00:00
OK_SKIP_LABELS = {"release", "pr-backport", "pr-cherrypick"}
CAN_BE_TESTED_LABEL = "can be tested"
2021-09-15 12:59:39 +00:00
DO_NOT_TEST_LABEL = "do not test"
FORCE_TESTS_LABEL = "force tests"
2022-03-29 17:28:18 +00:00
SUBMODULE_CHANGED_LABEL = "submodule changed"
2021-09-15 12:59:39 +00:00
# Individual trusted contirbutors who are not in any trusted organization.
# Can be changed in runtime: we will append users that we learned to be in
# a trusted org, to save GitHub API calls.
2022-01-13 11:06:50 +00:00
TRUSTED_CONTRIBUTORS = {
e.lower()
for e in [
"achimbab",
"adevyatova ", # DOCSUP
"Algunenano", # Raúl Marín, Tinybird
2022-01-15 12:23:48 +00:00
"amosbird",
2022-01-13 11:06:50 +00:00
"AnaUvarova", # DOCSUP
"anauvarova", # technical writer, Yandex
"annvsh", # technical writer, Yandex
"atereh", # DOCSUP
"azat",
"bharatnc", # Newbie, but already with many contributions.
2022-01-15 12:23:48 +00:00
"bobrik", # Seasoned contributor, CloudFlare
2022-01-13 11:06:50 +00:00
"BohuTANG",
"codyrobert", # Flickerbox engineer
"cwurm", # Employee
"damozhaeva", # DOCSUP
"den-crane",
"flickerbox-tom", # Flickerbox
"gyuton", # technical writer, Yandex
"hagen1778", # Roman Khavronenko, seasoned contributor
"hczhcz",
"hexiaoting", # Seasoned contributor
"ildus", # adjust, ex-pgpro
"javisantana", # a Spanish ClickHouse enthusiast, ex-Carto
"ka1bi4", # DOCSUP
"kirillikoff", # DOCSUP
"kitaisreal", # Seasoned contributor
"kreuzerkrieg",
"lehasm", # DOCSUP
"michon470", # DOCSUP
"MyroTk", # Tester in Altinity
"myrrc", # Michael Kot, Altinity
"nikvas0",
"nvartolomei",
"olgarev", # DOCSUP
"otrazhenia", # Yandex docs contractor
"pdv-ru", # DOCSUP
"podshumok", # cmake expert from QRator Labs
"s-mx", # Maxim Sabyanin, former employee, present contributor
"sevirov", # technical writer, Yandex
"spongedu", # Seasoned contributor
2022-02-18 12:59:47 +00:00
"taiyang-li",
2022-01-13 11:06:50 +00:00
"ucasFL", # Amos Bird's friend
"vdimir", # Employee
"vzakaznikov",
"YiuRULE",
"zlobober", # Developer of YT
"ilejn", # Arenadata, responsible for Kerberized Kafka
"thomoco", # ClickHouse
"BoloniniD", # Seasoned contributor, HSE
]
}
2021-09-15 12:59:39 +00:00
2022-03-29 13:48:57 +00:00
MAP_CATEGORY_TO_LABEL = {
"New Feature": "pr-feature",
"Bug Fix": "pr-bugfix",
"Bug Fix (user-visible misbehaviour in official stable or prestable release)": "pr-bugfix",
"Improvement": "pr-improvement",
"Performance Improvement": "pr-performance",
"Backward Incompatible Change": "pr-backward-incompatible",
"Build/Testing/Packaging Improvement": "pr-build",
2022-03-29 13:53:08 +00:00
"Build Improvement": "pr-build",
"Build/Testing Improvement": "pr-build",
"Build": "pr-build",
"Packaging Improvement": "pr-build",
2022-03-29 13:48:57 +00:00
"Not for changelog (changelog entry is not required)": "pr-not-for-changelog",
"Not for changelog": "pr-not-for-changelog",
"Documentation (changelog entry is not required)": "pr-documentation",
"Documentation": "pr-documentation",
# 'Other': doesn't match anything
}
2021-09-15 12:59:39 +00:00
def pr_is_by_trusted_user(pr_user_login, pr_user_orgs):
if pr_user_login.lower() in TRUSTED_CONTRIBUTORS:
logging.info("User '%s' is trusted", pr_user_login)
2021-09-15 12:59:39 +00:00
return True
logging.info("User '%s' is not trusted", pr_user_login)
2021-09-15 12:59:39 +00:00
for org_id in pr_user_orgs:
if org_id in TRUSTED_ORG_IDS:
2022-01-13 11:06:50 +00:00
logging.info(
"Org '%s' is trusted; will mark user %s as trusted",
org_id,
pr_user_login,
)
2021-09-15 12:59:39 +00:00
return True
logging.info("Org '%s' is not trusted", org_id)
2021-09-15 12:59:39 +00:00
return False
2022-01-13 11:06:50 +00:00
2021-09-15 12:59:39 +00:00
# Returns whether we should look into individual checks for this PR. If not, it
# can be skipped entirely.
# Returns can_run, description, labels_state
def should_run_checks_for_pr(pr_info: PRInfo) -> Tuple[bool, str, str]:
2021-09-15 12:59:39 +00:00
# Consider the labels and whether the user is trusted.
2021-12-22 08:13:04 +00:00
print("Got labels", pr_info.labels)
if FORCE_TESTS_LABEL in pr_info.labels:
return True, f"Labeled '{FORCE_TESTS_LABEL}'", "pending"
2021-09-15 12:59:39 +00:00
if DO_NOT_TEST_LABEL in pr_info.labels:
return False, f"Labeled '{DO_NOT_TEST_LABEL}'", "success"
2021-09-15 12:59:39 +00:00
if CAN_BE_TESTED_LABEL not in pr_info.labels and not pr_is_by_trusted_user(
2022-01-13 11:06:50 +00:00
pr_info.user_login, pr_info.user_orgs
):
return False, "Needs 'can be tested' label", "failure"
2021-09-15 12:59:39 +00:00
if OK_SKIP_LABELS.intersection(pr_info.labels):
return (
False,
"Don't try new checks for release/backports/cherry-picks",
"success",
)
2021-09-30 11:26:46 +00:00
return True, "No special conditions apply", "pending"
2021-09-15 12:59:39 +00:00
2021-11-26 14:00:09 +00:00
2022-01-13 11:08:31 +00:00
def check_pr_description(pr_info):
description = pr_info.body
2022-01-13 13:51:48 +00:00
lines = list(
map(lambda x: x.strip(), description.split("\n") if description else [])
)
lines = [re.sub(r"\s+", " ", line) for line in lines]
2022-01-13 11:08:31 +00:00
category = ""
entry = ""
i = 0
while i < len(lines):
if re.match(r"(?i)^[>*_ ]*change\s*log\s*category", lines[i]):
i += 1
if i >= len(lines):
break
# Can have one empty line between header and the category
# itself. Filter it out.
if not lines[i]:
i += 1
if i >= len(lines):
break
category = re.sub(r"^[-*\s]*", "", lines[i])
i += 1
# Should not have more than one category. Require empty line
# after the first found category.
if i >= len(lines):
break
if lines[i]:
second_category = re.sub(r"^[-*\s]*", "", lines[i])
result_status = (
"More than one changelog category specified: '"
+ category
+ "', '"
+ second_category
+ "'"
)
2022-03-29 13:48:57 +00:00
return result_status[:140], category
2022-01-13 11:08:31 +00:00
elif re.match(
r"(?i)^[>*_ ]*(short\s*description|change\s*log\s*entry)", lines[i]
):
i += 1
# Can have one empty line between header and the entry itself.
# Filter it out.
if i < len(lines) and not lines[i]:
i += 1
# All following lines until empty one are the changelog entry.
entry_lines = []
while i < len(lines) and lines[i]:
entry_lines.append(lines[i])
i += 1
entry = " ".join(entry_lines)
# Don't accept changelog entries like '...'.
entry = re.sub(r"[#>*_.\- ]", "", entry)
else:
i += 1
if not category:
2022-03-29 13:48:57 +00:00
return "Changelog category is empty", category
2022-01-13 11:08:31 +00:00
# Filter out the PR categories that are not for changelog.
if re.match(
r"(?i)doc|((non|in|not|un)[-\s]*significant)|(not[ ]*for[ ]*changelog)",
category,
):
2022-03-29 13:48:57 +00:00
return "", category
2022-01-13 11:08:31 +00:00
if not entry:
2022-03-29 13:48:57 +00:00
return f"Changelog entry required for category '{category}'", category
2022-01-13 11:08:31 +00:00
2022-03-29 13:48:57 +00:00
return "", category
2022-01-13 11:08:31 +00:00
2021-09-15 12:59:39 +00:00
if __name__ == "__main__":
logging.basicConfig(level=logging.INFO)
2022-03-29 17:28:18 +00:00
pr_info = PRInfo(need_orgs=True, pr_event_from_api=True, need_changed_files=True)
can_run, description, labels_state = should_run_checks_for_pr(pr_info)
gh = Github(get_best_robot_token())
commit = get_commit(gh, pr_info.sha)
2022-01-13 11:08:31 +00:00
2022-03-29 13:48:57 +00:00
description_report, category = check_pr_description(pr_info)
2022-03-30 08:58:34 +00:00
pr_labels_to_add = []
pr_labels_to_remove = []
2022-03-29 17:50:06 +00:00
if (
category in MAP_CATEGORY_TO_LABEL
and MAP_CATEGORY_TO_LABEL[category] not in pr_info.labels
):
2022-03-30 08:58:34 +00:00
pr_labels_to_add.append(MAP_CATEGORY_TO_LABEL[category])
for label in pr_info.labels:
if label in MAP_CATEGORY_TO_LABEL and label not in pr_labels_to_add:
pr_labels_to_remove.append(label)
2022-03-29 13:48:57 +00:00
2022-03-29 17:28:18 +00:00
if pr_info.has_changes_in_submodules():
2022-03-30 08:58:34 +00:00
pr_labels_to_add.append(SUBMODULE_CHANGED_LABEL)
2022-03-29 17:50:06 +00:00
elif SUBMODULE_CHANGED_LABEL in pr_info.labels:
2022-03-30 08:58:34 +00:00
pr_labels_to_remove.append(SUBMODULE_CHANGED_LABEL)
if pr_labels_to_add:
post_labels(gh, pr_info, pr_labels_to_add)
if pr_labels_to_remove:
remove_labels(gh, pr_info, pr_labels_to_remove)
2022-03-29 17:28:18 +00:00
2022-01-13 11:08:31 +00:00
if description_report:
print("::notice ::Cannot run, description does not match the template")
2022-01-26 12:23:20 +00:00
logging.info(
"PR body doesn't match the template: (start)\n%s\n(end)", pr_info.body
)
2022-01-13 11:08:31 +00:00
url = (
f"{GITHUB_SERVER_URL}/{GITHUB_REPOSITORY}/"
"blob/master/.github/PULL_REQUEST_TEMPLATE.md?plain=1"
)
commit.create_status(
context=NAME,
2022-03-29 13:48:57 +00:00
description=description_report[:139],
2022-01-13 11:08:31 +00:00
state="failure",
target_url=url,
)
sys.exit(1)
url = GITHUB_RUN_URL
2021-09-15 12:59:39 +00:00
if not can_run:
2021-09-16 10:39:36 +00:00
print("::notice ::Cannot run")
2022-01-13 11:06:50 +00:00
commit.create_status(
context=NAME, description=description, state=labels_state, target_url=url
2022-01-13 11:06:50 +00:00
)
2021-09-15 12:59:39 +00:00
sys.exit(1)
2021-09-15 13:36:48 +00:00
else:
2022-01-13 11:06:50 +00:00
if "pr-documentation" in pr_info.labels or "pr-doc-fix" in pr_info.labels:
commit.create_status(
context=NAME,
description="Skipping checks for documentation",
state="success",
target_url=url,
)
2021-10-26 10:34:12 +00:00
print("::notice ::Can run, but it's documentation PR, skipping")
else:
print("::notice ::Can run")
2022-01-13 11:06:50 +00:00
commit.create_status(
context=NAME, description=description, state="pending", target_url=url
)