thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-10-19 06:50:50 +00:00
Code Issues Packages Projects Releases Wiki Activity
97f2a2213e
ClickHouse/tests/queries/0_stateless/01040_distributed_directory_monitor_batch_inserts.reference

5 lines
8 B
Plaintext
Raw Normal View History

Add checksum for extra info/query in distributed sends This extras includes: - server revision - query settings - query Otherwise the code can try to interpret data, and got for instance std::length_error exception, which is not catched (to mark the part as broken). Also this will protect from the corruptions on disk. And add a simple test, since dbms/tests/integration/test_insert_into_distributed too complex. Also simplify the code by using readStringBinary() over readVarUInt()+b.readStrict() (this also gains additional checks that string is not bigger then 1GB). Refs: #4852 (8ef7f3589a5170ea6aae33872b3bfd815623db9e) v2: avoid ABI breakage (suggested by @vitlibar) v3: minor code fixes (suggested by @vitlibar) and as a consequence clang-8 build fix v4: drop DBMS_MIN_REVISION_WITH_EXTRAS_CHECKSUM_IN_DIST_BATCH and also revert some renames to make the patch cleaner
2019-11-10 11:11:57 +00:00
0
1
0
1
Reference in New Issue Copy Permalink