thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-04 21:42:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
aff66742e7
ClickHouse/tests/queries/0_stateless/01865_aggregator_overflow_row.reference

13 lines
27 B
Plaintext
Raw Normal View History

Fix SIGSEGV for external GROUP BY and overflow row Overflow row is used for GROUP BY if all of the above is true: - WITH TOTALS is requested - max_rows_to_group_by > 0 - group_by_overflow_mode = any - totals_mode != after_having_exclusive And in case of overflow row and external GROUP BY, once the temporary file dumps to disk it resets without_key data variant to nullptr, so any subsequent dump to disk will cause SIGSEGV. Fix this, by recreating without_key data variant after dumping to disk, instead of reseting to nullptr. And also add sanity check (LOGICAL_ERROR) to make error more deterministic in case of such error. Found with fuzzer [1]. [1]: https://clickhouse-test-reports.s3.yandex.net/23929/e7027e052998540ee660d186727e20f9555b729d/fuzzer_ubsan/report.html#fail1
2021-05-08 09:56:42 +00:00
1
1
1
1
1
1
1
1
1
1
Check that totals correctly calculated in 01865_aggregator_overflow_row Change aggregation function to uniqCombined() to check this.
2021-05-08 17:43:01 +00:00
10020
Reference in New Issue Copy Permalink