From 8d7319ccab75d8f5a401bdd63697f7bd6508d27f Mon Sep 17 00:00:00 2001
From: Duc Canh Le <duccanh.le@ahrefs.com>
Date: Wed, 14 Aug 2024 10:18:00 +0000
Subject: [PATCH] fix wrong format of SYSTEM SYNC REPLICA query

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
---
 src/Parsers/ASTSystemQuery.cpp                | 45 ++++++++++---------
 ...03205_system_sync_replica_format.reference |  1 +
 .../03205_system_sync_replica_format.sql      |  1 +
 3 files changed, 25 insertions(+), 22 deletions(-)
 create mode 100644 tests/queries/0_stateless/03205_system_sync_replica_format.reference
 create mode 100644 tests/queries/0_stateless/03205_system_sync_replica_format.sql

diff --git a/src/Parsers/ASTSystemQuery.cpp b/src/Parsers/ASTSystemQuery.cpp
index a730ea0ba3d..7780544d5c2 100644
--- a/src/Parsers/ASTSystemQuery.cpp
+++ b/src/Parsers/ASTSystemQuery.cpp
@@ -198,6 +198,29 @@ void ASTSystemQuery::formatImpl(const FormatSettings & settings, FormatState & s
                 print_database_table();
             }
 
+            if (sync_replica_mode != SyncReplicaMode::DEFAULT)
+            {
+                settings.ostr << ' ';
+                print_keyword(magic_enum::enum_name(sync_replica_mode));
+
+                // If the mode is LIGHTWEIGHT and specific source replicas are specified
+                if (sync_replica_mode == SyncReplicaMode::LIGHTWEIGHT && !src_replicas.empty())
+                {
+                    settings.ostr << ' ';
+                    print_keyword("FROM");
+                    settings.ostr << ' ';
+
+                    bool first = true;
+                    for (const auto & src : src_replicas)
+                    {
+                        if (!first)
+                            settings.ostr << ", ";
+                        first = false;
+                        settings.ostr << quoteString(src);
+                    }
+                }
+            }
+
             if (query_settings)
             {
                 settings.ostr << (settings.hilite ? hilite_keyword : "") << settings.nl_or_ws << "SETTINGS " << (settings.hilite ? hilite_none : "");
@@ -233,28 +256,6 @@ void ASTSystemQuery::formatImpl(const FormatSettings & settings, FormatState & s
                 print_identifier(disk);
             }
 
-            if (sync_replica_mode != SyncReplicaMode::DEFAULT)
-            {
-                settings.ostr << ' ';
-                print_keyword(magic_enum::enum_name(sync_replica_mode));
-
-                // If the mode is LIGHTWEIGHT and specific source replicas are specified
-                if (sync_replica_mode == SyncReplicaMode::LIGHTWEIGHT && !src_replicas.empty())
-                {
-                    settings.ostr << ' ';
-                    print_keyword("FROM");
-                    settings.ostr << ' ';
-
-                    bool first = true;
-                    for (const auto & src : src_replicas)
-                    {
-                        if (!first)
-                            settings.ostr << ", ";
-                        first = false;
-                        settings.ostr << quoteString(src);
-                    }
-                }
-            }
             break;
         }
         case Type::SYNC_DATABASE_REPLICA:
diff --git a/tests/queries/0_stateless/03205_system_sync_replica_format.reference b/tests/queries/0_stateless/03205_system_sync_replica_format.reference
new file mode 100644
index 00000000000..aad51dd90b0
--- /dev/null
+++ b/tests/queries/0_stateless/03205_system_sync_replica_format.reference
@@ -0,0 +1 @@
+SYSTEM SYNC REPLICA db.`table` LIGHTWEIGHT
diff --git a/tests/queries/0_stateless/03205_system_sync_replica_format.sql b/tests/queries/0_stateless/03205_system_sync_replica_format.sql
new file mode 100644
index 00000000000..329bce80afc
--- /dev/null
+++ b/tests/queries/0_stateless/03205_system_sync_replica_format.sql
@@ -0,0 +1 @@
+SELECT formatQuery('SYSTEM SYNC REPLICA db.table LIGHTWEIGHT');