thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-23 18:20:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix some PVS-Studio warnings

Browse Source
This commit is contained in:
Alexey Milovidov 2021-05-08 17:54:08 +03:00
parent 8d62c42eb9
commit 022667a190
3 changed files with 11 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Functions/greatCircleDistance.cpp
View File

@ -187,8 +187,8 @@ float distance(float lon1deg, float lat1deg, float lon2deg, float lat2deg)
/// This is linear interpolation between two table items at index "latitude_midpoint_index" and "latitude_midpoint_index + 1".
float k_lat;
float k_lon;
float k_lat{};
float k_lon{};
if constexpr (method == Method::SPHERE_DEGREES)
{

6
src/Processors/Transforms/FillingTransform.cpp
View File

@ -36,6 +36,8 @@ FillingTransform::FillingTransform(
auto max_type = Field::Types::Null;
WhichDataType which(type);
DataTypePtr to_type;
/// TODO Wrong results for big integers.
if (isInteger(type) || which.isDateOrDateTime())
{
max_type = Field::Types::Int64;
@ -46,9 +48,7 @@ FillingTransform::FillingTransform(
max_type = Field::Types::Float64;
to_type = std::make_shared<DataTypeFloat64>();
}
if (descr.fill_from.getType() > max_type || descr.fill_to.getType() > max_type
|| descr.fill_step.getType() > max_type)
else
return false;
descr.fill_from = convertFieldToType(descr.fill_from, *to_type);

21
src/Storages/System/StorageSystemTables.cpp
View File

@ -389,14 +389,13 @@ protected:
src_index += 2;
StorageMetadataPtr metadata_snapshot;
if (table != nullptr)
metadata_snapshot = table->getInMemoryMetadataPtr();
assert(table != nullptr);
metadata_snapshot = table->getInMemoryMetadataPtr();
ASTPtr expression_ptr;
if (columns_mask[src_index++])
{
assert(metadata_snapshot != nullptr);
if ((expression_ptr = metadata_snapshot->getPartitionKeyAST()))
if (metadata_snapshot && (expression_ptr = metadata_snapshot->getPartitionKeyAST()))
res_columns[res_index++]->insert(queryToString(expression_ptr));
else
res_columns[res_index++]->insertDefault();
@ -404,8 +403,7 @@ protected:
if (columns_mask[src_index++])
{
assert(metadata_snapshot != nullptr);
if ((expression_ptr = metadata_snapshot->getSortingKey().expression_list_ast))
if (metadata_snapshot && (expression_ptr = metadata_snapshot->getSortingKey().expression_list_ast))
res_columns[res_index++]->insert(queryToString(expression_ptr));
else
res_columns[res_index++]->insertDefault();
@ -413,8 +411,7 @@ protected:
if (columns_mask[src_index++])
{
assert(metadata_snapshot != nullptr);
if ((expression_ptr = metadata_snapshot->getPrimaryKey().expression_list_ast))
if (metadata_snapshot && (expression_ptr = metadata_snapshot->getPrimaryKey().expression_list_ast))
res_columns[res_index++]->insert(queryToString(expression_ptr));
else
res_columns[res_index++]->insertDefault();
@ -422,8 +419,7 @@ protected:
if (columns_mask[src_index++])
{
assert(metadata_snapshot != nullptr);
if ((expression_ptr = metadata_snapshot->getSamplingKeyAST()))
if (metadata_snapshot && (expression_ptr = metadata_snapshot->getSamplingKeyAST()))
res_columns[res_index++]->insert(queryToString(expression_ptr));
else
res_columns[res_index++]->insertDefault();
@ -431,7 +427,6 @@ protected:
if (columns_mask[src_index++])
{
assert(table != nullptr);
auto policy = table->getStoragePolicy();
if (policy)
res_columns[res_index++]->insert(policy->getName());
@ -441,7 +436,6 @@ protected:
if (columns_mask[src_index++])
{
assert(table != nullptr);
auto total_rows = table->totalRows(context->getSettingsRef());
if (total_rows)
res_columns[res_index++]->insert(*total_rows);
@ -451,7 +445,6 @@ protected:
if (columns_mask[src_index++])
{
assert(table != nullptr);
auto total_bytes = table->totalBytes(context->getSettingsRef());
if (total_bytes)
res_columns[res_index++]->insert(*total_bytes);
@ -461,7 +454,6 @@ protected:
if (columns_mask[src_index++])
{
assert(table != nullptr);
auto lifetime_rows = table->lifetimeRows();
if (lifetime_rows)
res_columns[res_index++]->insert(*lifetime_rows);
@ -471,7 +463,6 @@ protected:
if (columns_mask[src_index++])
{
assert(table != nullptr);
auto lifetime_bytes = table->lifetimeBytes();
if (lifetime_bytes)
res_columns[res_index++]->insert(*lifetime_bytes);