thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 00:22:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix UBSan report in avgWeighted

Browse Source
This commit is contained in:
Alexey Milovidov 2021-01-23 03:17:58 +03:00
parent 7d2108d4e9
commit 02d28c1f9b
3 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/AggregateFunctions/AggregateFunctionAvgWeighted.h
View File

@ -28,7 +28,7 @@ public:
using ValueT = MaxFieldType<Value, Weight>;
void add(AggregateDataPtr place, const IColumn ** columns, size_t row_num, Arena *) const override
void NO_SANITIZE_UNDEFINED add(AggregateDataPtr place, const IColumn ** columns, size_t row_num, Arena *) const override
{
const auto& weights = static_cast<const DecimalOrVectorCol<Weight> &>(*columns[1]);

1
tests/queries/0_stateless/01668_avg_weighted_ubsan.reference Normal file
View File

@ -0,0 +1 @@
-0

1
tests/queries/0_stateless/01668_avg_weighted_ubsan.sql Normal file
View File

@ -0,0 +1 @@
SELECT round(avgWeighted(x, y)) FROM (SELECT 1023 AS x, 1000000000 AS y UNION ALL SELECT 10 AS x, -9223372036854775808 AS y);