From 043c625898883259011b755317975ee880cac692 Mon Sep 17 00:00:00 2001
From: avogar <avogar@clickhouse.com>
Date: Wed, 27 Mar 2024 19:19:08 +0000
Subject: [PATCH] Don't treat Bool and number variants as suspicious

---
 src/Interpreters/parseColumnsListForTableFunction.cpp         | 4 ++++
 .../03032_variant_bool_number_not_suspicious.reference        | 1 +
 .../0_stateless/03032_variant_bool_number_not_suspicious.sql  | 4 ++++
 3 files changed, 9 insertions(+)
 create mode 100644 tests/queries/0_stateless/03032_variant_bool_number_not_suspicious.reference
 create mode 100644 tests/queries/0_stateless/03032_variant_bool_number_not_suspicious.sql

diff --git a/src/Interpreters/parseColumnsListForTableFunction.cpp b/src/Interpreters/parseColumnsListForTableFunction.cpp
index 30a41c090d5..498c6dc4c84 100644
--- a/src/Interpreters/parseColumnsListForTableFunction.cpp
+++ b/src/Interpreters/parseColumnsListForTableFunction.cpp
@@ -86,6 +86,10 @@ void validateDataType(const DataTypePtr & type_to_check, const DataTypeValidatio
                 {
                     for (size_t j = i + 1; j < variants.size(); ++j)
                     {
+                        /// Don't consider bool as similar to something (like number).
+                        if (isBool(variants[i]) || isBool(variants[j]))
+                            continue;
+
                         if (auto supertype = tryGetLeastSupertype(DataTypes{variants[i], variants[j]}))
                         {
                             throw Exception(
diff --git a/tests/queries/0_stateless/03032_variant_bool_number_not_suspicious.reference b/tests/queries/0_stateless/03032_variant_bool_number_not_suspicious.reference
new file mode 100644
index 00000000000..27ba77ddaf6
--- /dev/null
+++ b/tests/queries/0_stateless/03032_variant_bool_number_not_suspicious.reference
@@ -0,0 +1 @@
+true
diff --git a/tests/queries/0_stateless/03032_variant_bool_number_not_suspicious.sql b/tests/queries/0_stateless/03032_variant_bool_number_not_suspicious.sql
new file mode 100644
index 00000000000..b7609d34f58
--- /dev/null
+++ b/tests/queries/0_stateless/03032_variant_bool_number_not_suspicious.sql
@@ -0,0 +1,4 @@
+set allow_experimental_variant_type=1;
+set allow_suspicious_variant_types=0;
+select 'true'::Bool::Variant(UInt32, Bool);
+