From fc2e7159f01069b37fb8912f6a689c2ea0575dde Mon Sep 17 00:00:00 2001 From: DanRoscigno Date: Tue, 13 Sep 2022 12:40:16 -0400 Subject: [PATCH 1/5] add note about privs --- docs/en/sql-reference/statements/delete.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/en/sql-reference/statements/delete.md b/docs/en/sql-reference/statements/delete.md index 487dfc87f9a..18ebc241d51 100644 --- a/docs/en/sql-reference/statements/delete.md +++ b/docs/en/sql-reference/statements/delete.md @@ -35,3 +35,9 @@ An [alternative way to delete rows](./alter/delete.md) in ClickHouse is `ALTER T Even though deletes are becoming more lightweight in ClickHouse, they should still not be used as aggressively as on OLTP system. Ligthweight deletes are currently efficient for wide parts, but for compact parts they can be a heavyweight operation, and it may be better to use `ALTER TABLE` for some scenarios. ::: +:::note +DELETE FROM requires the ALTER DELETE privledge: +```sql +grant ALTER DELETE ON db.table to username; +``` +::: From 64bd1ea77ae5e3b79d5a89c418c922314f3e9ff0 Mon Sep 17 00:00:00 2001 From: DanRoscigno Date: Tue, 13 Sep 2022 12:42:24 -0400 Subject: [PATCH 2/5] spelling --- docs/en/sql-reference/statements/delete.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/en/sql-reference/statements/delete.md b/docs/en/sql-reference/statements/delete.md index 18ebc241d51..0a886618348 100644 --- a/docs/en/sql-reference/statements/delete.md +++ b/docs/en/sql-reference/statements/delete.md @@ -36,7 +36,7 @@ Even though deletes are becoming more lightweight in ClickHouse, they should sti ::: :::note -DELETE FROM requires the ALTER DELETE privledge: +DELETE FROM requires the ALTER DELETE privilege: ```sql grant ALTER DELETE ON db.table to username; ``` From e85b2221363cd296fe47ff1aba8c2b597f48b181 Mon Sep 17 00:00:00 2001 From: Rich Raposa Date: Tue, 13 Sep 2022 10:54:47 -0600 Subject: [PATCH 3/5] Update delete.md --- docs/en/sql-reference/statements/delete.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/en/sql-reference/statements/delete.md b/docs/en/sql-reference/statements/delete.md index 0a886618348..65cd073e530 100644 --- a/docs/en/sql-reference/statements/delete.md +++ b/docs/en/sql-reference/statements/delete.md @@ -32,7 +32,7 @@ SET allow_experimental_lightweight_delete = true; An [alternative way to delete rows](./alter/delete.md) in ClickHouse is `ALTER TABLE ... DELETE`, which might be more efficient if you do bulk deletes only occasionally and don't need the operation to be applied instantly. In most use cases the new lightweight `DELETE FROM` behavior will be considerably faster. :::warning -Even though deletes are becoming more lightweight in ClickHouse, they should still not be used as aggressively as on OLTP system. Ligthweight deletes are currently efficient for wide parts, but for compact parts they can be a heavyweight operation, and it may be better to use `ALTER TABLE` for some scenarios. +Even though deletes are becoming more lightweight in ClickHouse, they should still not be used as aggressively as an OLTP system. Ligthweight deletes are currently efficient for wide parts, but for compact parts they can be a heavyweight operation, and it may be better to use `ALTER TABLE` for some scenarios. ::: :::note From b833c39dcf577710993de9bb760b83c97ff95f13 Mon Sep 17 00:00:00 2001 From: Rich Raposa Date: Tue, 13 Sep 2022 10:55:26 -0600 Subject: [PATCH 4/5] Update delete.md --- docs/en/sql-reference/statements/delete.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/en/sql-reference/statements/delete.md b/docs/en/sql-reference/statements/delete.md index 65cd073e530..ef3487ff754 100644 --- a/docs/en/sql-reference/statements/delete.md +++ b/docs/en/sql-reference/statements/delete.md @@ -36,7 +36,7 @@ Even though deletes are becoming more lightweight in ClickHouse, they should sti ::: :::note -DELETE FROM requires the ALTER DELETE privilege: +`DELETE FROM` requires the `ALTER DELETE` privilege: ```sql grant ALTER DELETE ON db.table to username; ``` From 078b9bff3c4c23add4395b1c8b044f74af3c9b8f Mon Sep 17 00:00:00 2001 From: Dan Roscigno Date: Tue, 13 Sep 2022 13:18:01 -0400 Subject: [PATCH 5/5] Update docs/en/sql-reference/statements/delete.md --- docs/en/sql-reference/statements/delete.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/en/sql-reference/statements/delete.md b/docs/en/sql-reference/statements/delete.md index ef3487ff754..0dc6cc0d09a 100644 --- a/docs/en/sql-reference/statements/delete.md +++ b/docs/en/sql-reference/statements/delete.md @@ -32,7 +32,7 @@ SET allow_experimental_lightweight_delete = true; An [alternative way to delete rows](./alter/delete.md) in ClickHouse is `ALTER TABLE ... DELETE`, which might be more efficient if you do bulk deletes only occasionally and don't need the operation to be applied instantly. In most use cases the new lightweight `DELETE FROM` behavior will be considerably faster. :::warning -Even though deletes are becoming more lightweight in ClickHouse, they should still not be used as aggressively as an OLTP system. Ligthweight deletes are currently efficient for wide parts, but for compact parts they can be a heavyweight operation, and it may be better to use `ALTER TABLE` for some scenarios. +Even though deletes are becoming more lightweight in ClickHouse, they should still not be used as aggressively as on an OLTP system. Ligthweight deletes are currently efficient for wide parts, but for compact parts they can be a heavyweight operation, and it may be better to use `ALTER TABLE` for some scenarios. ::: :::note