thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-02 12:32:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce maximum allowable size of |HashSet|.

Browse Source
This commit is contained in:
Ivan Lezhankin 2018-10-25 16:17:29 +03:00
parent 68138a76f8
commit 0592081f2f
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dbms/src/AggregateFunctions/AggregateFunctionUniqCombined.h
View File

@ -71,7 +71,11 @@ struct AggregateFunctionUniqCombinedDataWithKey
{ {
// TODO(ilezhankin): pre-generate values for |UniqCombinedBiasData|, // TODO(ilezhankin): pre-generate values for |UniqCombinedBiasData|,
// at the moment gen-bias-data.py script doesn't work. // at the moment gen-bias-data.py script doesn't work.
using Set = CombinedCardinalityEstimator<Key, HashSet<Key, TrivialHash, HashTableGrower<>>, 16, K - 3, K, TrivialHash, Key>;
// We want to migrate from |HashSet| to |HyperLogLogCounter| when the sizes in memory become almost equal.
// The size per element in |HashSet| is sizeof(Key)*2 bytes, and the overall size of |HyperLogLogCounter| is 2^K * 6 bits.
// For Key=UInt32 we can calculate: 2^X * 4 * 2 ≤ 2^(K-3) * 6 ⇒ X ≤ K-4.
using Set = CombinedCardinalityEstimator<Key, HashSet<Key, TrivialHash, HashTableGrower<>>, 16, K - 4, K, TrivialHash, Key>;
Set set; Set set;
}; };
@ -82,7 +86,7 @@ struct AggregateFunctionUniqCombinedDataWithKey<Key, 17>
using Set = CombinedCardinalityEstimator<Key, using Set = CombinedCardinalityEstimator<Key,
HashSet<Key, TrivialHash, HashTableGrower<>>, HashSet<Key, TrivialHash, HashTableGrower<>>,
16, 16,
14, 13,
17, 17,
TrivialHash, TrivialHash,
Key, Key,