thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-10 01:25:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix special case of trivial regexp

Browse Source 
Previously, we would alsays set 1 in case of a trivial regex (which is
correct). If someone in future builds a negated operator, then this
will produce wrong results. Right now, negation of regexp (SQL: NOT
MATCH) is implemented at a higher level, so we are safe and this is more
a preventive fix.
This commit is contained in:
Robert Schulze 2022-05-24 22:59:48 +02:00
parent 01ab7b9bad
commit 05e4fa7df1
No known key found for this signature in database
GPG Key ID: 26703B55FB13728A
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Functions/MatchImpl.h
View File

@ -179,7 +179,7 @@ struct MatchImpl
if (!regexp->getRE2()) /// An empty regexp. Always matches. if (!regexp->getRE2()) /// An empty regexp. Always matches.
{ {
if (haystack_size) if (haystack_size)
memset(res.data(), 1, haystack_size * sizeof(res[0])); memset(res.data(), !negate, haystack_size * sizeof(res[0]));
} }
else else
{ {
@ -338,7 +338,7 @@ struct MatchImpl
if (!regexp->getRE2()) /// An empty regexp. Always matches. if (!regexp->getRE2()) /// An empty regexp. Always matches.
{ {
if (haystack_size) if (haystack_size)
memset(res.data(), 1, haystack_size * sizeof(res[0])); memset(res.data(), !negate, haystack_size * sizeof(res[0]));
} }
else else
{ {
@ -490,7 +490,7 @@ struct MatchImpl
{ {
if (!regexp.getRE2()) /// An empty regexp. Always matches. if (!regexp.getRE2()) /// An empty regexp. Always matches.
{ {
res[i] = 1; res[i] = !negate;
} }
else else
{ {
@ -604,7 +604,7 @@ struct MatchImpl
{ {
if (!regexp.getRE2()) /// An empty regexp. Always matches. if (!regexp.getRE2()) /// An empty regexp. Always matches.
{ {
res[i] = 1; res[i] = !negate;
} }
else else
{ {