thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 16:42:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improvements based on PR review

Browse Source
This commit is contained in:
Raúl Marín 2022-04-06 10:48:12 +02:00
parent dce0c9f059
commit 060f5118f0
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Common/DNSResolver.cpp
View File

@ -123,7 +123,10 @@ static DNSResolver::IPAddresses resolveIPAddressImpl(const std::string & host)
} }
if (addresses.empty()) if (addresses.empty())
{
ProfileEvents::increment(ProfileEvents::DNSError);
throw Exception("Not found address of host: " + host, ErrorCodes::DNS_ERROR); throw Exception("Not found address of host: " + host, ErrorCodes::DNS_ERROR);
}
return addresses; return addresses;
} }
@ -142,8 +145,8 @@ static String reverseResolveImpl(const Poco::Net::IPAddress & address)
struct DNSResolver::Impl struct DNSResolver::Impl
{ {
using HostWithConsecutiveFailures = std::unordered_map<String, UInt8>; using HostWithConsecutiveFailures = std::unordered_map<String, UInt32>;
using AddressWithConsecutiveFailures = std::unordered_map<Poco::Net::IPAddress, UInt8>; using AddressWithConsecutiveFailures = std::unordered_map<Poco::Net::IPAddress, UInt32>;
CachedFn<&resolveIPAddressImpl> cache_host; CachedFn<&resolveIPAddressImpl> cache_host;
CachedFn<&reverseResolveImpl> cache_address; CachedFn<&reverseResolveImpl> cache_address;
@ -275,7 +278,6 @@ bool DNSResolver::updateCacheImpl(
tryLogCurrentException(log, __PRETTY_FUNCTION__); tryLogCurrentException(log, __PRETTY_FUNCTION__);
continue; continue;
} }
ProfileEvents::increment(ProfileEvents::DNSError);
if (!lost_elems.empty()) if (!lost_elems.empty())
lost_elems += ", "; lost_elems += ", ";
lost_elems += cacheElemToString(it->first); lost_elems += cacheElemToString(it->first);