thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-27 10:02:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not generate empty chunks in AggregatingInOrderTransform

Browse Source 
This is just a micro optimization and it should not affect anything,
real fixes are in separate patches (previous and next).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
This commit is contained in:
Azat Khuzhin 2022-01-14 16:49:04 +03:00
parent d9a64d1f86
commit 06402386eb
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Processors/Transforms/AggregatingInOrderTransform.cpp
View File

@ -255,6 +255,8 @@ void AggregatingInOrderTransform::generate()
res.getByPosition(i + res_key_columns.size()).column = std::move(res_aggregate_columns[i]); res.getByPosition(i + res_key_columns.size()).column = std::move(res_aggregate_columns[i]);
to_push_chunk = convertToChunk(res); to_push_chunk = convertToChunk(res);
if (!to_push_chunk.getNumRows())
return;
/// Clear arenas to allow to free them, when chunk will reach the end of pipeline. /// Clear arenas to allow to free them, when chunk will reach the end of pipeline.
/// It's safe clear them here, because columns with aggregate functions already holds them. /// It's safe clear them here, because columns with aggregate functions already holds them.