Sanitize "Flaky tests", remove trailing dots

This commit is contained in:
Mikhail f. Shiryaev 2023-05-02 12:42:26 +02:00
parent b423e04ab0
commit 08d203e158
No known key found for this signature in database
GPG Key ID: 4B02ED204C7D93F4

View File

@ -417,7 +417,7 @@ CHECK_DESCRIPTIONS = [
"AST fuzzer", "AST fuzzer",
"Runs randomly generated queries to catch program errors. " "Runs randomly generated queries to catch program errors. "
"The build type is optionally given in parenthesis. " "The build type is optionally given in parenthesis. "
"If it fails, ask a maintainer for help.", "If it fails, ask a maintainer for help",
lambda x: x.startswith("AST fuzzer"), lambda x: x.startswith("AST fuzzer"),
), ),
CheckDescription( CheckDescription(
@ -439,13 +439,13 @@ CHECK_DESCRIPTIONS = [
"information to fix the error, but you might have to reproduce the failure " "information to fix the error, but you might have to reproduce the failure "
"locally. The <b>cmake</b> options can be found in the build log, grepping for " "locally. The <b>cmake</b> options can be found in the build log, grepping for "
'<b>cmake</b>. Use these options and follow the <a href="' '<b>cmake</b>. Use these options and follow the <a href="'
'https://clickhouse.com/docs/en/development/build">general build process</a>.', 'https://clickhouse.com/docs/en/development/build">general build process</a>',
lambda x: x.startswith("ClickHouse") and x.endswith("build check"), lambda x: x.startswith("ClickHouse") and x.endswith("build check"),
), ),
CheckDescription( CheckDescription(
"Compatibility check", "Compatibility check",
"Checks that <b>clickhouse</b> binary runs on distributions with old libc " "Checks that <b>clickhouse</b> binary runs on distributions with old libc "
"versions. If it fails, ask a maintainer for help.", "versions. If it fails, ask a maintainer for help",
lambda x: x.startswith("Compatibility check"), lambda x: x.startswith("Compatibility check"),
), ),
CheckDescription( CheckDescription(
@ -465,12 +465,18 @@ CHECK_DESCRIPTIONS = [
"omitting some. If it fails, further checks are not started until it is fixed. " "omitting some. If it fails, further checks are not started until it is fixed. "
"Look at the report to see which tests fail, then reproduce the failure " "Look at the report to see which tests fail, then reproduce the failure "
'locally as described <a href="https://clickhouse.com/docs/en/development/' 'locally as described <a href="https://clickhouse.com/docs/en/development/'
'tests#functional-test-locally">here</a>.', 'tests#functional-test-locally">here</a>',
lambda x: x == "Fast test", lambda x: x == "Fast test",
), ),
CheckDescription( CheckDescription(
"Flaky tests", "Flaky tests",
"Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read https://clickhouse.com/blog/decorating-a-christmas-tree-with-the-help-of-flaky-tests/", "Checks if new added or modified tests are flaky by running them repeatedly, "
"in parallel, with more randomization. Functional tests are run 100 times "
"with address sanitizer, and additional randomization of thread scheduling. "
"Integrational tests are run up to 10 times. If at least once a new test has "
"failed, or was too long, this check will be red. We don't allow flaky tests, "
'read <a href="https://clickhouse.com/blog/decorating-a-christmas-tree-with-'
'the-help-of-flaky-tests/">the doc</a>',
lambda x: "tests flaky check" in x, lambda x: "tests flaky check" in x,
), ),
CheckDescription( CheckDescription(
@ -506,37 +512,37 @@ CHECK_DESCRIPTIONS = [
"Sqllogic", "Sqllogic",
"Run clickhouse on the " "Run clickhouse on the "
'<a href="https://www.sqlite.org/sqllogictest">sqllogic</a> ' '<a href="https://www.sqlite.org/sqllogictest">sqllogic</a> '
"test set against sqlite and checks that all statements are passed.", "test set against sqlite and checks that all statements are passed",
lambda x: x.startswith("Sqllogic test"), lambda x: x.startswith("Sqllogic test"),
), ),
CheckDescription( CheckDescription(
"SQLancer", "SQLancer",
"Fuzzing tests that detect logical bugs with " "Fuzzing tests that detect logical bugs with "
'<a href="https://github.com/sqlancer/sqlancer">SQLancer</a> tool.', '<a href="https://github.com/sqlancer/sqlancer">SQLancer</a> tool',
lambda x: x.startswith("SQLancer"), lambda x: x.startswith("SQLancer"),
), ),
CheckDescription( CheckDescription(
"Stateful tests", "Stateful tests",
"Runs stateful functional tests for ClickHouse binaries built in various " "Runs stateful functional tests for ClickHouse binaries built in various "
"configurations -- release, debug, with sanitizers, etc.", "configurations -- release, debug, with sanitizers, etc",
lambda x: x.startswith("Stateful tests ("), lambda x: x.startswith("Stateful tests ("),
), ),
CheckDescription( CheckDescription(
"Stateless tests", "Stateless tests",
"Runs stateless functional tests for ClickHouse binaries built in various " "Runs stateless functional tests for ClickHouse binaries built in various "
"configurations -- release, debug, with sanitizers, etc.", "configurations -- release, debug, with sanitizers, etc",
lambda x: x.startswith("Stateless tests ("), lambda x: x.startswith("Stateless tests ("),
), ),
CheckDescription( CheckDescription(
"Stress test", "Stress test",
"Runs stateless functional tests concurrently from several clients to detect " "Runs stateless functional tests concurrently from several clients to detect "
"concurrency-related errors.", "concurrency-related errors",
lambda x: x.startswith("Stress test ("), lambda x: x.startswith("Stress test ("),
), ),
CheckDescription( CheckDescription(
"Style Check", "Style Check",
"Runs a set of checks to keep the code style clean. If some of tests failed, " "Runs a set of checks to keep the code style clean. If some of tests failed, "
"see the related log from the report.", "see the related log from the report",
lambda x: x == "Style Check", lambda x: x == "Style Check",
), ),
CheckDescription( CheckDescription(
@ -548,7 +554,7 @@ CHECK_DESCRIPTIONS = [
"Upgrade check", "Upgrade check",
"Runs stress tests on server version from last release and then tries to " "Runs stress tests on server version from last release and then tries to "
"upgrade it to the version from the PR. It checks if the new server can " "upgrade it to the version from the PR. It checks if the new server can "
"successfully startup without any errors, crashes or sanitizer asserts.", "successfully startup without any errors, crashes or sanitizer asserts",
lambda x: x.startswith("Upgrade check ("), lambda x: x.startswith("Upgrade check ("),
), ),
CheckDescription( CheckDescription(