From 09995013085511b206388816f896cdf251535ee4 Mon Sep 17 00:00:00 2001 From: Igor Nikonov Date: Fri, 7 Jun 2024 14:35:06 +0000 Subject: [PATCH] Fix crash in in-order coordinator --- src/Storages/MergeTree/ParallelReplicasReadingCoordinator.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Storages/MergeTree/ParallelReplicasReadingCoordinator.cpp b/src/Storages/MergeTree/ParallelReplicasReadingCoordinator.cpp index f3318a48883..9eea40c4c5f 100644 --- a/src/Storages/MergeTree/ParallelReplicasReadingCoordinator.cpp +++ b/src/Storages/MergeTree/ParallelReplicasReadingCoordinator.cpp @@ -887,7 +887,9 @@ void InOrderCoordinator::doHandleInitialAllRangesAnnouncement(InitialAllRa ++stats[announcement.replica_num].number_of_requests; - if (new_rows_to_read > 0) + /// FIXME: this code updating total_rows_to_read but it needs to be done only once since we're taking working set from initiator + /// util I missing something, it seems this code is not necessary if working set is taken from initiator (todo: check it) + if (new_rows_to_read > 0 && progress_callback) { Progress progress; progress.total_rows_to_read = new_rows_to_read;