From 09b782a52e8f0a558ee5a75474825a6474dde760 Mon Sep 17 00:00:00 2001 From: Azat Khuzhin Date: Mon, 18 Oct 2021 10:39:52 +0300 Subject: [PATCH] Increase default wait of the server start in clickhouse-test Set --server-check-retries to 90 (and this is ~45 seconds), since right now sometimes it is not enough [1]. [1]: https://clickhouse-test-reports.s3.yandex.net/30191/0e34a9d550cfe6924fe575871f36c44dd44acdaa/functional_stateless_tests_(memory).html#fail1 And the reason I guess is clickhouse-test had been rewritten to http.client in #30065, and since now it does not need to execute clickhouse-client binary, which in debug/sanitizers builds can take also sometime. That said that with clickhouse-client for hung check it was not 15 seconds, but more (each clickhouse-client requires 0.6sec with sanitizers for simple SELECT 1, while w/o 0.1second, also too much should be optimized) --- tests/clickhouse-test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/clickhouse-test b/tests/clickhouse-test index 1e8c2bfb8ad..5f6960e57c4 100755 --- a/tests/clickhouse-test +++ b/tests/clickhouse-test @@ -1309,7 +1309,7 @@ if __name__ == '__main__': parser.add_argument('-j', '--jobs', default=1, nargs='?', type=int, help='Run all tests in parallel') parser.add_argument('--test-runs', default=1, nargs='?', type=int, help='Run each test many times (useful for e.g. flaky check)') parser.add_argument('-U', '--unified', default=3, type=int, help='output NUM lines of unified context') - parser.add_argument('-r', '--server-check-retries', default=30, type=int, help='Num of tries to execute SELECT 1 before tests started') + parser.add_argument('-r', '--server-check-retries', default=90, type=int, help='Num of tries to execute SELECT 1 before tests started') parser.add_argument('--db-engine', help='Database engine name') parser.add_argument('--replicated-database', action='store_true', default=False, help='Run tests with Replicated database engine') parser.add_argument('--fast-tests-only', action='store_true', default=False, help='Run only fast tests (the tests without the "no-fasttest" tag)')