thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 08:40:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed error found by M.Filimonov (missing check for maximum size of FixedString leading to overflow in arithmetic) [#CLICKHOUSE-2].

Browse Source
This commit is contained in:
Alexey Milovidov 2017-12-18 23:43:10 +03:00
parent bee53d483f
commit 09fa34c764
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dbms/src/DataTypes/DataTypeFixedString.h
View File

@ -2,6 +2,8 @@
#include <DataTypes/IDataType.h>
#define MAX_FIXEDSTRING_SIZE 0xFFFFFF
namespace DB
{
@ -24,6 +26,8 @@ public:
{
if (n == 0)
throw Exception("FixedString size must be positive", ErrorCodes::ARGUMENT_OUT_OF_BOUND);
if (n > MAX_FIXEDSTRING_SIZE)
throw Exception("FixedString size is too large", ErrorCodes::ARGUMENT_OUT_OF_BOUND);
}
std::string getName() const override;