thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-27 01:51:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

speedup merge selection: async exists check for selected parts [#CLICKHOUSE-3802]

Browse Source
This commit is contained in:
Alexey Zatelepin 2018-07-04 18:44:12 +03:00 committed by alexey-milovidov
parent 116ed0a59e
commit 0a46d231ed
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
dbms/src/Storages/StorageReplicatedMergeTree.cpp
View File

@ -2282,14 +2282,20 @@ bool StorageReplicatedMergeTree::createLogEntryToMergeParts(
bool deduplicate, bool deduplicate,
ReplicatedMergeTreeLogEntryData * out_log_entry) ReplicatedMergeTreeLogEntryData * out_log_entry)
{ {
bool all_in_zk = true; std::vector<std::future<zkutil::ExistsResponse>> exists_futures;
exists_futures.reserve(parts.size());
for (const auto & part : parts) for (const auto & part : parts)
exists_futures.emplace_back(zookeeper->asyncExists(replica_path + "/parts/" + part->name));
bool all_in_zk = true;
for (size_t i = 0; i < parts.size(); ++i)
{ {
/// If there is no information about part in ZK, we will not merge it. /// If there is no information about part in ZK, we will not merge it.
if (!zookeeper->exists(replica_path + "/parts/" + part->name)) if (exists_futures[i].get().error == ZooKeeperImpl::ZooKeeper::ZNONODE)
{ {
all_in_zk = false; all_in_zk = false;
const auto & part = parts[i];
if (part->modification_time + MAX_AGE_OF_LOCAL_PART_THAT_WASNT_ADDED_TO_ZOOKEEPER < time(nullptr)) if (part->modification_time + MAX_AGE_OF_LOCAL_PART_THAT_WASNT_ADDED_TO_ZOOKEEPER < time(nullptr))
{ {
LOG_WARNING(log, "Part " << part->name << " (that was selected for merge)" LOG_WARNING(log, "Part " << part->name << " (that was selected for merge)"
@ -2300,6 +2306,7 @@ bool StorageReplicatedMergeTree::createLogEntryToMergeParts(
} }
} }
} }
if (!all_in_zk) if (!all_in_zk)
return false; return false;