mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-09-20 00:30:49 +00:00
Activated a bunch of LLVM 12/13/14 clang-tidy warnings
Omitted new checks which produce too many matches or which are controversial (e.g. readability-identifier-length). New checks: - misc-misleading-bidirectional + misc-misleading-identifier Detects potential attack as described in the Trojan Source attack - modernize-macro-to-enum Replaces groups of adjacent macros with an unscoped anonymous enum - modernize-shrink-to-fit Replace copy and swap tricks on shrinkable containers with the shrink_to_fit() method call - modernize-use-transparent-functors Prefer transparent functors to non-transparent ones - modernize-use-uncaught-exceptions This check will warn on calls to std::uncaught_exception and replace them with calls to std::uncaught_exceptions (uncaught_exception was deprecated with C++17) - performance-no-int-to-ptr Diagnoses every integer to pointer cast - readability-duplicate-include Looks for duplicate includes and removes them - readability-redundant-preprocessor Finds potentially redundant preprocessor directives - bugprone-lambda-function-name Checks for attempts to get the name of a function from within a lambda expression - bugprone-redundant-branch-condition Finds condition variables in nested if statements that were also checked in the outer if statement and were not changed - bugprone-shared-ptr-array-mismatch Finds initializations of C++ shared pointers to non-array type that are initialized with an array - bugprone-stringview-nullptr Checks for various ways that the const CharT* constructor of std::basic_string_view can be passed a null argument and replaces them with the default constructor in most cases - bugprone-suspicious-memory-comparison Finds potentially incorrect calls to memcmp() based on properties of the arguments
This commit is contained in:
parent
66f62b2ba6
commit
0a4eccb73e
14
.clang-tidy
14
.clang-tidy
@ -1,4 +1,6 @@
|
||||
Checks: '-*,
|
||||
misc-misleading-bidirectional,
|
||||
misc-misleading-identifier,
|
||||
misc-misplaced-const,
|
||||
misc-redundant-expression,
|
||||
misc-static-assert,
|
||||
@ -11,15 +13,19 @@ Checks: '-*,
|
||||
|
||||
modernize-avoid-bind,
|
||||
modernize-loop-convert,
|
||||
modernize-macro-to-enum,
|
||||
modernize-make-shared,
|
||||
modernize-make-unique,
|
||||
modernize-raw-string-literal,
|
||||
modernize-redundant-void-arg,
|
||||
modernize-replace-random-shuffle,
|
||||
modernize-shrink-to-fit,
|
||||
modernize-use-bool-literals,
|
||||
modernize-use-equals-default,
|
||||
modernize-use-equals-delete,
|
||||
modernize-use-nullptr,
|
||||
modernize-use-transparent-functors,
|
||||
modernize-use-uncaught-exceptions,
|
||||
modernize-use-using,
|
||||
|
||||
performance-faster-string-find,
|
||||
@ -30,6 +36,7 @@ Checks: '-*,
|
||||
performance-move-const-arg,
|
||||
performance-move-constructor-init,
|
||||
performance-no-automatic-move,
|
||||
performance-no-int-to-ptr,
|
||||
performance-noexcept-move-constructor,
|
||||
performance-trivially-destructible,
|
||||
performance-unnecessary-copy-initialization,
|
||||
@ -41,6 +48,7 @@ Checks: '-*,
|
||||
readability-convert-member-functions-to-static,
|
||||
readability-delete-null-pointer,
|
||||
readability-deleted-default,
|
||||
readability-duplicate-include,
|
||||
readability-identifier-naming,
|
||||
readability-inconsistent-declaration-parameter-name,
|
||||
readability-make-member-function-const,
|
||||
@ -51,6 +59,7 @@ Checks: '-*,
|
||||
readability-redundant-control-flow,
|
||||
readability-redundant-function-ptr-dereference,
|
||||
readability-redundant-member-init,
|
||||
readability-redundant-preprocessor,
|
||||
readability-redundant-smartptr-get,
|
||||
readability-redundant-string-cstr,
|
||||
readability-redundant-string-init,
|
||||
@ -71,6 +80,7 @@ Checks: '-*,
|
||||
bugprone-incorrect-roundings,
|
||||
bugprone-infinite-loop,
|
||||
bugprone-integer-division,
|
||||
bugprone-lambda-function-name,
|
||||
bugprone-macro-parentheses,
|
||||
bugprone-macro-repeated-side-effects,
|
||||
bugprone-misplaced-operator-in-strlen-in-alloc,
|
||||
@ -80,15 +90,19 @@ Checks: '-*,
|
||||
bugprone-multiple-statement-macro,
|
||||
bugprone-parent-virtual-call,
|
||||
bugprone-posix-return,
|
||||
bugprone-redundant-branch-condition,
|
||||
bugprone-reserved-identifier,
|
||||
bugprone-shared-ptr-array-mismatch,
|
||||
bugprone-signed-char-misuse,
|
||||
bugprone-sizeof-container,
|
||||
bugprone-sizeof-expression,
|
||||
bugprone-string-constructor,
|
||||
bugprone-string-integer-assignment,
|
||||
bugprone-string-literal-with-embedded-nul,
|
||||
bugprone-stringview-nullptr,
|
||||
bugprone-suspicious-enum-usage,
|
||||
bugprone-suspicious-include,
|
||||
bugprone-suspicious-memory-comparison,
|
||||
bugprone-suspicious-memset-usage,
|
||||
bugprone-suspicious-missing-comma,
|
||||
bugprone-suspicious-string-compare,
|
||||
|
@ -53,7 +53,7 @@ ColumnSparse::ColumnSparse(MutableColumnPtr && values_, MutableColumnPtr && offs
|
||||
|
||||
#ifndef NDEBUG
|
||||
const auto & offsets_data = getOffsetsData();
|
||||
const auto * it = std::adjacent_find(offsets_data.begin(), offsets_data.end(), std::greater_equal<UInt64>());
|
||||
const auto * it = std::adjacent_find(offsets_data.begin(), offsets_data.end(), std::greater_equal<>());
|
||||
if (it != offsets_data.end())
|
||||
throw Exception(ErrorCodes::LOGICAL_ERROR, "Offsets of ColumnSparse must be strictly sorted");
|
||||
#endif
|
||||
|
@ -373,8 +373,8 @@ struct MinHashImpl
|
||||
std::map<UInt64, BytesRef, Comp> values;
|
||||
};
|
||||
|
||||
using MaxHeap = Heap<std::less<size_t>>;
|
||||
using MinHeap = Heap<std::greater<size_t>>;
|
||||
using MaxHeap = Heap<std::less<>>;
|
||||
using MinHeap = Heap<std::greater<>>;
|
||||
|
||||
static ALWAYS_INLINE inline void ngramHashASCII(
|
||||
MinHeap & min_heap,
|
||||
|
@ -12,7 +12,6 @@
|
||||
#include <Parsers/Lexer.h>
|
||||
#include <Parsers/parseQuery.h>
|
||||
#include <Parsers/ParserQuery.h>
|
||||
#include <Parsers/ASTSelectQuery.h>
|
||||
#include <Parsers/ASTSelectWithUnionQuery.h>
|
||||
|
||||
namespace DB
|
||||
|
Loading…
Reference in New Issue
Block a user