From 41b557f926cadbed6e62020064ae6d419d33d001 Mon Sep 17 00:00:00 2001
From: Antonio Andelic <antonio@clickhouse.com>
Date: Thu, 17 Nov 2022 09:16:47 +0000
Subject: [PATCH] Disable DeltaLake and hudi table functions in readonly mode

---
 .../{TableFunctionDelta.cpp => TableFunctionDeltaLake.cpp}  | 6 +++---
 .../{TableFunctionDelta.h => TableFunctionDeltaLake.h}      | 0
 src/TableFunctions/TableFunctionHudi.cpp                    | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
 rename src/TableFunctions/{TableFunctionDelta.cpp => TableFunctionDeltaLake.cpp} (96%)
 rename src/TableFunctions/{TableFunctionDelta.h => TableFunctionDeltaLake.h} (100%)

diff --git a/src/TableFunctions/TableFunctionDelta.cpp b/src/TableFunctions/TableFunctionDeltaLake.cpp
similarity index 96%
rename from src/TableFunctions/TableFunctionDelta.cpp
rename to src/TableFunctions/TableFunctionDeltaLake.cpp
index 25ea2aaa77f..0f5801d57ac 100644
--- a/src/TableFunctions/TableFunctionDelta.cpp
+++ b/src/TableFunctions/TableFunctionDeltaLake.cpp
@@ -13,7 +13,7 @@
 #    include <Storages/StorageDelta.h>
 #    include <Storages/StorageURL.h>
 #    include <Storages/checkAndGetLiteralArgument.h>
-#    include <TableFunctions/TableFunctionDelta.h>
+#    include <TableFunctions/TableFunctionDeltaLake.h>
 #    include <TableFunctions/TableFunctionFactory.h>
 #    include "registerTableFunctions.h"
 
@@ -160,9 +160,9 @@ void registerTableFunctionDelta(TableFunctionFactory & factory)
     factory.registerFunction<TableFunctionDelta>(
         {.documentation
          = {R"(The table function can be used to read the DeltaLake table stored on object store.)",
-            Documentation::Examples{{"hudi", "SELECT * FROM deltaLake(url, access_key_id, secret_access_key)"}},
+            Documentation::Examples{{"deltaLake", "SELECT * FROM deltaLake(url, access_key_id, secret_access_key)"}},
             Documentation::Categories{"DataLake"}},
-         .allow_readonly = true});
+         .allow_readonly = false});
 }
 
 }
diff --git a/src/TableFunctions/TableFunctionDelta.h b/src/TableFunctions/TableFunctionDeltaLake.h
similarity index 100%
rename from src/TableFunctions/TableFunctionDelta.h
rename to src/TableFunctions/TableFunctionDeltaLake.h
diff --git a/src/TableFunctions/TableFunctionHudi.cpp b/src/TableFunctions/TableFunctionHudi.cpp
index b1db90da550..2e27d192b58 100644
--- a/src/TableFunctions/TableFunctionHudi.cpp
+++ b/src/TableFunctions/TableFunctionHudi.cpp
@@ -162,7 +162,7 @@ void registerTableFunctionHudi(TableFunctionFactory & factory)
          = {R"(The table function can be used to read the Hudi table stored on object store.)",
             Documentation::Examples{{"hudi", "SELECT * FROM hudi(url, access_key_id, secret_access_key)"}},
             Documentation::Categories{"DataLake"}},
-         .allow_readonly = true});
+         .allow_readonly = false});
 }
 }