thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-10 01:25:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: ubsan, EMPTY_STRING_REF constant

Browse Source
This commit is contained in:
myrrc 2020-07-29 01:08:09 +03:00
parent cf696afd4c
commit 0f5b089270
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
base/common/StringRef.h
View File

@ -45,9 +45,11 @@ struct StringRef
constexpr explicit operator std::string_view() const { return {data, size}; }
};
/// Holds {nullptr, 0};
/// Here constexpr doesn't implicate inline, see https://www.viva64.com/en/w/v1043/
constexpr const inline StringRef EMPTY_STRING_REF{};
/// nullptr can't be used because the StringRef values are used in SipHash's pointer arithmetics
/// and the UBSan thinks that something like nullptr + 8 is UB.
constexpr const inline char empty_string_ref_addr{};
constexpr const inline StringRef EMPTY_STRING_REF{&empty_string_ref_addr, 0};
using StringRefs = std::vector<StringRef>;