Fix conversion to/from big endian.

src/Functions/FileEncryption.h

@@ -6,6 +6,7 @@
 #include <openssl/engine.h>
 
 #include <IO/ReadBuffer.h>
+#include <IO/ReadHelpers.h>
 #include <IO/WriteBuffer.h>
 #include <IO/WriteHelpers.h>
 
@@ -50,28 +51,16 @@ public:
 private:
     String ToBigEndianString(DB::UInt128 value) const
     {
-        size_t size = kIVSize;
+        WriteBufferFromOwnString out;
-        size_t dev = std::pow(2, CHAR_BIT);
+        writeBinaryBigEndian(value, out);
-        String result(size, 0);
+        return std::move(out.str());
-
-        for (size_t i = 0; i != size; ++i)
-        {
-            result[size - i - 1] = value % dev;
-            value /= dev;
-        }
-        return result;
     }
 
     DB::UInt128 FromBigEndianString(const String & str) const
     {
-        size_t dev = std::pow(2, CHAR_BIT);
+        ReadBufferFromMemory in{str.data(), str.length()};
-        DB::UInt128 result = 0;
+        DB::UInt128 result;
-
+        readBinaryBigEndian(result, in);
-        for (auto c : str)
-        {
-            result *= dev;
-            result += c % dev;
-        }
         return result;
     }
 

src/IO/ReadHelpers.h

@@ -921,6 +921,17 @@ readBinaryBigEndian(T & x, ReadBuffer & buf)    /// Assuming little endian archi
         x = __builtin_bswap64(x);
 }
 
+template <typename T>
+inline std::enable_if_t<is_big_int_v<T>, void>
+readBinaryBigEndian(T & x, ReadBuffer & buf)    /// Assuming little endian architecture.
+{
+    for (size_t i = 0; i != std::size(x.items); ++i)
+    {
+        auto & item = x.items[std::size(x.items) - i - 1];
+        readBinaryBigEndian(item, buf);
+    }
+}
+
 
 /// Generic methods to read value in text tab-separated format.
 template <typename T>

src/IO/WriteHelpers.h

@@ -1099,6 +1099,17 @@ writeBinaryBigEndian(T x, WriteBuffer & buf)    /// Assuming little endian archi
     writePODBinary(x, buf);
 }
 
+template <typename T>
+inline std::enable_if_t<is_big_int_v<T>, void>
+writeBinaryBigEndian(const T & x, WriteBuffer & buf)    /// Assuming little endian architecture.
+{
+    for (size_t i = 0; i != std::size(x.items); ++i)
+    {
+        const auto & item = x.items[std::size(x.items) - i - 1];
+        writeBinaryBigEndian(item, buf);
+    }
+}
+
 struct PcgSerializer
 {
     static void serializePcg32(const pcg32_fast & rng, WriteBuffer & buf)