From 101a13b5c37c3d4835187bbedbecaeb9f5190b0e Mon Sep 17 00:00:00 2001 From: zhang2014 Date: Wed, 24 Jun 2020 14:04:21 +0800 Subject: [PATCH] ISSUES-4006 remove unused code --- .../MySQL/MaterializeMySQLSyncThread.cpp | 20 +++---------------- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/src/Databases/MySQL/MaterializeMySQLSyncThread.cpp b/src/Databases/MySQL/MaterializeMySQLSyncThread.cpp index caaec6defcf..0ecf3c49d10 100644 --- a/src/Databases/MySQL/MaterializeMySQLSyncThread.cpp +++ b/src/Databases/MySQL/MaterializeMySQLSyncThread.cpp @@ -62,7 +62,7 @@ static inline DatabaseMaterializeMySQL & getDatabase(const String & database_nam if (DatabaseMaterializeMySQL * database_materialize = typeid_cast(database.get())) return *database_materialize; - throw Exception("", ErrorCodes::LOGICAL_ERROR); + throw Exception("LOGICAL_ERROR: cannot cast to DatabaseMaterializeMySQL, it is a bug.", ErrorCodes::LOGICAL_ERROR); } MaterializeMySQLSyncThread::~MaterializeMySQLSyncThread() @@ -77,8 +77,7 @@ MaterializeMySQLSyncThread::~MaterializeMySQLSyncThread() } sync_cond.notify_one(); -// sync_task_handler->deactivate(); -// flush_task_handler->deactivate(); + /// TODO: join thread } } catch (...) @@ -97,17 +96,6 @@ MaterializeMySQLSyncThread::MaterializeMySQLSyncThread( startSynchronization(); } -/*MaterializeMySQLSyncThread::MaterializeMySQLSyncThread( - const Context & context, const String & database_name_, const String & metadata_path_ - , const ASTStorage * database_engine_define_, const String & mysql_database_name_, mysqlxx::Pool && pool_ - , MySQLClient && client_ , std::unique_ptr settings_) - : DatabaseMaterializeMySQL(std::make_shared(database_name_, metadata_path_, context), database_engine_define_->clone(), "MaterializeMySQLSyncThread") - , global_context(context.getGlobalContext()), metadata_path(metadata_path_), mysql_database_name(mysql_database_name_) - , pool(std::move(pool_)), client(std::move(client_)), settings(std::move(settings_)) -{ - -}*/ - void MaterializeMySQLSyncThread::synchronization() { setThreadName("MySQLDBSync"); @@ -158,9 +146,7 @@ void MaterializeMySQLSyncThread::synchronization() void MaterializeMySQLSyncThread::startSynchronization() { -// if (!background_thread_pool->joinable()) -// throw Exception("", ErrorCodes::LOGICAL_ERROR); - + /// TODO: reset exception. background_thread_pool = std::make_unique([this]() { synchronization(); }); }