mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-09-19 16:20:50 +00:00
Merge pull request #66973 from ClickHouse/add_more_diagnostics
[CI Fest] Add more diagnostics in case of digest mismatch for DatabaseReplicated (investigating #64936)
This commit is contained in:
alesapin
GitHub
commit
103fcef3b4
@ -671,92 +671,96 @@ void DatabaseReplicated::stopLoading()
|
||||
DatabaseAtomic::stopLoading();
|
||||
}
|
||||
|
||||
bool DatabaseReplicated::checkDigestValid(const ContextPtr & local_context, bool debug_check /* = true */) const
|
||||
void DatabaseReplicated::dumpLocalTablesForDebugOnly(const ContextPtr & local_context) const
|
||||
{
|
||||
if (debug_check)
|
||||
auto table_names = getAllTableNames(context.lock());
|
||||
for (const auto & table_name : table_names)
|
||||
{
|
||||
/// Reduce number of debug checks
|
||||
if (thread_local_rng() % 16)
|
||||
return true;
|
||||
auto ast_ptr = tryGetCreateTableQuery(table_name, local_context);
|
||||
if (ast_ptr)
|
||||
LOG_DEBUG(log, "[local] Table {} create query is {}", table_name, queryToString(ast_ptr));
|
||||
else
|
||||
LOG_DEBUG(log, "[local] Table {} has no create query", table_name);
|
||||
}
|
||||
|
||||
LOG_TEST(log, "Current in-memory metadata digest: {}", tables_metadata_digest);
|
||||
|
||||
/// Database is probably being dropped
|
||||
if (!local_context->getZooKeeperMetadataTransaction() && (!ddl_worker || !ddl_worker->isCurrentlyActive()))
|
||||
return true;
|
||||
|
||||
UInt64 local_digest = 0;
|
||||
{
|
||||
std::lock_guard lock{mutex};
|
||||
for (const auto & table : TSA_SUPPRESS_WARNING_FOR_READ(tables))
|
||||
local_digest += getMetadataHash(table.first);
|
||||
}
|
||||
|
||||
if (local_digest != tables_metadata_digest)
|
||||
{
|
||||
LOG_ERROR(log, "Digest of local metadata ({}) is not equal to in-memory digest ({})", local_digest, tables_metadata_digest);
|
||||
return false;
|
||||
}
|
||||
|
||||
/// Do not check digest in Keeper after internal subquery, it's probably not committed yet
|
||||
if (local_context->isInternalSubquery())
|
||||
return true;
|
||||
|
||||
/// Check does not make sense to check digest in Keeper during recovering
|
||||
if (is_recovering)
|
||||
return true;
|
||||
|
||||
String zk_digest = getZooKeeper()->get(replica_path + "/digest");
|
||||
String local_digest_str = toString(local_digest);
|
||||
if (zk_digest != local_digest_str)
|
||||
{
|
||||
LOG_ERROR(log, "Digest of local metadata ({}) is not equal to digest in Keeper ({})", local_digest_str, zk_digest);
|
||||
return false;
|
||||
}
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
void DatabaseReplicated::checkQueryValid(const ASTPtr & query, ContextPtr query_context) const
|
||||
void DatabaseReplicated::dumpTablesInZooKeeperForDebugOnly() const
|
||||
{
|
||||
/// Replicas will set correct name of current database in query context (database name can be different on replicas)
|
||||
if (auto * ddl_query = dynamic_cast<ASTQueryWithTableAndOutput *>(query.get()))
|
||||
UInt32 max_log_ptr;
|
||||
auto table_name_to_metadata = tryGetConsistentMetadataSnapshot(getZooKeeper(), max_log_ptr);
|
||||
for (const auto & [table_name, create_table_query] : table_name_to_metadata)
|
||||
{
|
||||
if (ddl_query->getDatabase() != getDatabaseName())
|
||||
throw Exception(ErrorCodes::UNKNOWN_DATABASE, "Database was renamed");
|
||||
ddl_query->database.reset();
|
||||
|
||||
if (auto * create = query->as<ASTCreateQuery>())
|
||||
auto query_ast = parseQueryFromMetadataInZooKeeper(table_name, create_table_query);
|
||||
if (query_ast)
|
||||
{
|
||||
if (create->storage)
|
||||
checkTableEngine(*create, *create->storage, query_context);
|
||||
LOG_DEBUG(log, "[zookeeper] Table {} create query is {}", table_name, queryToString(query_ast));
|
||||
}
|
||||
else
|
||||
{
|
||||
LOG_DEBUG(log, "[zookeeper] Table {} has no create query", table_name);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (create->targets)
|
||||
void DatabaseReplicated::tryCompareLocalAndZooKeeperTablesAndDumpDiffForDebugOnly(const ContextPtr & local_context) const
|
||||
{
|
||||
UInt32 max_log_ptr;
|
||||
auto table_name_to_metadata_in_zk = tryGetConsistentMetadataSnapshot(getZooKeeper(), max_log_ptr);
|
||||
auto table_names_local = getAllTableNames(local_context);
|
||||
|
||||
if (table_name_to_metadata_in_zk.size() != table_names_local.size())
|
||||
LOG_DEBUG(log, "Amount of tables in zk {} locally {}", table_name_to_metadata_in_zk.size(), table_names_local.size());
|
||||
|
||||
std::unordered_set<std::string> checked_tables;
|
||||
|
||||
for (const auto & table_name : table_names_local)
|
||||
{
|
||||
auto local_ast_ptr = tryGetCreateTableQuery(table_name, local_context);
|
||||
if (table_name_to_metadata_in_zk.contains(table_name))
|
||||
{
|
||||
checked_tables.insert(table_name);
|
||||
auto create_table_query_in_zk = table_name_to_metadata_in_zk[table_name];
|
||||
auto zk_ast_ptr = parseQueryFromMetadataInZooKeeper(table_name, create_table_query_in_zk);
|
||||
|
||||
if (local_ast_ptr == nullptr && zk_ast_ptr == nullptr)
|
||||
{
|
||||
for (const auto & inner_table_engine : create->targets->getInnerEngines())
|
||||
checkTableEngine(*create, *inner_table_engine, query_context);
|
||||
LOG_DEBUG(log, "AST for table {} is the same (nullptr) in local and ZK", table_name);
|
||||
}
|
||||
else if (local_ast_ptr != nullptr && zk_ast_ptr != nullptr && queryToString(local_ast_ptr) != queryToString(zk_ast_ptr))
|
||||
{
|
||||
LOG_DEBUG(log, "AST differs for table {}, local {}, in zookeeper {}", table_name, queryToString(local_ast_ptr), queryToString(zk_ast_ptr));
|
||||
}
|
||||
else if (local_ast_ptr == nullptr)
|
||||
{
|
||||
LOG_DEBUG(log, "AST differs for table {}, local nullptr, in zookeeper {}", table_name, queryToString(zk_ast_ptr));
|
||||
}
|
||||
else if (zk_ast_ptr == nullptr)
|
||||
{
|
||||
LOG_DEBUG(log, "AST differs for table {}, local {}, in zookeeper nullptr", table_name, queryToString(local_ast_ptr));
|
||||
}
|
||||
else
|
||||
{
|
||||
LOG_DEBUG(log, "AST for table {} is the same in local and ZK", table_name);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (const auto * query_alter = query->as<ASTAlterQuery>())
|
||||
{
|
||||
for (const auto & command : query_alter->command_list->children)
|
||||
else
|
||||
{
|
||||
if (!isSupportedAlterTypeForOnClusterDDLQuery(command->as<ASTAlterCommand&>().type))
|
||||
throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Unsupported type of ALTER query");
|
||||
if (local_ast_ptr == nullptr)
|
||||
LOG_DEBUG(log, "Table {} exists locally, but missing in ZK", table_name);
|
||||
else
|
||||
LOG_DEBUG(log, "Table {} exists locally with AST {}, but missing in ZK", table_name, queryToString(local_ast_ptr));
|
||||
}
|
||||
}
|
||||
|
||||
if (auto * query_drop = query->as<ASTDropQuery>())
|
||||
for (const auto & [table_name, table_metadata] : table_name_to_metadata_in_zk)
|
||||
{
|
||||
if (query_drop->kind == ASTDropQuery::Kind::Detach && query_context->getSettingsRef().database_replicated_always_detach_permanently)
|
||||
query_drop->permanently = true;
|
||||
if (query_drop->kind == ASTDropQuery::Kind::Detach && !query_drop->permanently)
|
||||
throw Exception(ErrorCodes::INCORRECT_QUERY, "DETACH TABLE is not allowed for Replicated databases. "
|
||||
"Use DETACH TABLE PERMANENTLY or SYSTEM RESTART REPLICA or set "
|
||||
"database_replicated_always_detach_permanently to 1");
|
||||
if (!checked_tables.contains(table_name))
|
||||
{
|
||||
auto zk_ast_ptr = parseQueryFromMetadataInZooKeeper(table_name, table_metadata);
|
||||
if (zk_ast_ptr == nullptr)
|
||||
LOG_DEBUG(log, "Table {} exists in ZK with AST {}, but missing locally", table_name, queryToString(zk_ast_ptr));
|
||||
else
|
||||
LOG_DEBUG(log, "Table {} exists in ZK, but missing locally", table_name);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@ -839,6 +843,107 @@ void DatabaseReplicated::checkTableEngine(const ASTCreateQuery & query, ASTStora
|
||||
"to distinguish different shards and replicas");
|
||||
}
|
||||
|
||||
bool DatabaseReplicated::checkDigestValid(const ContextPtr & local_context, bool debug_check /* = true */) const
|
||||
{
|
||||
if (debug_check)
|
||||
{
|
||||
/// Reduce number of debug checks
|
||||
if (thread_local_rng() % 16)
|
||||
return true;
|
||||
}
|
||||
|
||||
LOG_TEST(log, "Current in-memory metadata digest: {}", tables_metadata_digest);
|
||||
|
||||
/// Database is probably being dropped
|
||||
if (!local_context->getZooKeeperMetadataTransaction() && (!ddl_worker || !ddl_worker->isCurrentlyActive()))
|
||||
return true;
|
||||
|
||||
UInt64 local_digest = 0;
|
||||
{
|
||||
std::lock_guard lock{mutex};
|
||||
for (const auto & table : TSA_SUPPRESS_WARNING_FOR_READ(tables))
|
||||
local_digest += getMetadataHash(table.first);
|
||||
}
|
||||
|
||||
if (local_digest != tables_metadata_digest)
|
||||
{
|
||||
LOG_ERROR(log, "Digest of local metadata ({}) is not equal to in-memory digest ({})", local_digest, tables_metadata_digest);
|
||||
|
||||
#ifndef NDEBUG
|
||||
dumpLocalTablesForDebugOnly(local_context);
|
||||
dumpTablesInZooKeeperForDebugOnly();
|
||||
tryCompareLocalAndZooKeeperTablesAndDumpDiffForDebugOnly(local_context);
|
||||
#endif
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
/// Do not check digest in Keeper after internal subquery, it's probably not committed yet
|
||||
if (local_context->isInternalSubquery())
|
||||
return true;
|
||||
|
||||
/// Check does not make sense to check digest in Keeper during recovering
|
||||
if (is_recovering)
|
||||
return true;
|
||||
|
||||
String zk_digest = getZooKeeper()->get(replica_path + "/digest");
|
||||
String local_digest_str = toString(local_digest);
|
||||
if (zk_digest != local_digest_str)
|
||||
{
|
||||
LOG_ERROR(log, "Digest of local metadata ({}) is not equal to digest in Keeper ({})", local_digest_str, zk_digest);
|
||||
#ifndef NDEBUG
|
||||
dumpLocalTablesForDebugOnly(local_context);
|
||||
dumpTablesInZooKeeperForDebugOnly();
|
||||
tryCompareLocalAndZooKeeperTablesAndDumpDiffForDebugOnly(local_context);
|
||||
#endif
|
||||
return false;
|
||||
}
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
void DatabaseReplicated::checkQueryValid(const ASTPtr & query, ContextPtr query_context) const
|
||||
{
|
||||
/// Replicas will set correct name of current database in query context (database name can be different on replicas)
|
||||
if (auto * ddl_query = dynamic_cast<ASTQueryWithTableAndOutput *>(query.get()))
|
||||
{
|
||||
if (ddl_query->getDatabase() != getDatabaseName())
|
||||
throw Exception(ErrorCodes::UNKNOWN_DATABASE, "Database was renamed");
|
||||
ddl_query->database.reset();
|
||||
|
||||
if (auto * create = query->as<ASTCreateQuery>())
|
||||
{
|
||||
if (create->storage)
|
||||
checkTableEngine(*create, *create->storage, query_context);
|
||||
|
||||
if (create->targets)
|
||||
{
|
||||
for (const auto & inner_table_engine : create->targets->getInnerEngines())
|
||||
checkTableEngine(*create, *inner_table_engine, query_context);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (const auto * query_alter = query->as<ASTAlterQuery>())
|
||||
{
|
||||
for (const auto & command : query_alter->command_list->children)
|
||||
{
|
||||
if (!isSupportedAlterTypeForOnClusterDDLQuery(command->as<ASTAlterCommand&>().type))
|
||||
throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Unsupported type of ALTER query");
|
||||
}
|
||||
}
|
||||
|
||||
if (auto * query_drop = query->as<ASTDropQuery>())
|
||||
{
|
||||
if (query_drop->kind == ASTDropQuery::Kind::Detach && query_context->getSettingsRef().database_replicated_always_detach_permanently)
|
||||
query_drop->permanently = true;
|
||||
if (query_drop->kind == ASTDropQuery::Kind::Detach && !query_drop->permanently)
|
||||
throw Exception(ErrorCodes::INCORRECT_QUERY, "DETACH TABLE is not allowed for Replicated databases. "
|
||||
"Use DETACH TABLE PERMANENTLY or SYSTEM RESTART REPLICA or set "
|
||||
"database_replicated_always_detach_permanently to 1");
|
||||
}
|
||||
}
|
||||
|
||||
BlockIO DatabaseReplicated::tryEnqueueReplicatedDDL(const ASTPtr & query, ContextPtr query_context, QueryFlags flags)
|
||||
{
|
||||
waitDatabaseStarted();
|
||||
@ -1253,7 +1358,7 @@ void DatabaseReplicated::recoverLostReplica(const ZooKeeperPtr & current_zookeep
|
||||
current_zookeeper->set(replica_path + "/digest", toString(tables_metadata_digest));
|
||||
}
|
||||
|
||||
std::map<String, String> DatabaseReplicated::tryGetConsistentMetadataSnapshot(const ZooKeeperPtr & zookeeper, UInt32 & max_log_ptr)
|
||||
std::map<String, String> DatabaseReplicated::tryGetConsistentMetadataSnapshot(const ZooKeeperPtr & zookeeper, UInt32 & max_log_ptr) const
|
||||
{
|
||||
return getConsistentMetadataSnapshotImpl(zookeeper, {}, /* max_retries= */ 10, max_log_ptr);
|
||||
}
|
||||
@ -1314,7 +1419,7 @@ std::map<String, String> DatabaseReplicated::getConsistentMetadataSnapshotImpl(
|
||||
return table_name_to_metadata;
|
||||
}
|
||||
|
||||
ASTPtr DatabaseReplicated::parseQueryFromMetadataInZooKeeper(const String & node_name, const String & query)
|
||||
ASTPtr DatabaseReplicated::parseQueryFromMetadataInZooKeeper(const String & node_name, const String & query) const
|
||||
{
|
||||
ParserCreateQuery parser;
|
||||
String description = "in ZooKeeper " + zookeeper_path + "/metadata/" + node_name;
|
||||
|
||||
@ -109,14 +109,15 @@ private:
|
||||
void checkQueryValid(const ASTPtr & query, ContextPtr query_context) const;
|
||||
void checkTableEngine(const ASTCreateQuery & query, ASTStorage & storage, ContextPtr query_context) const;
|
||||
|
||||
|
||||
void recoverLostReplica(const ZooKeeperPtr & current_zookeeper, UInt32 our_log_ptr, UInt32 & max_log_ptr);
|
||||
|
||||
std::map<String, String> tryGetConsistentMetadataSnapshot(const ZooKeeperPtr & zookeeper, UInt32 & max_log_ptr);
|
||||
std::map<String, String> tryGetConsistentMetadataSnapshot(const ZooKeeperPtr & zookeeper, UInt32 & max_log_ptr) const;
|
||||
|
||||
std::map<String, String> getConsistentMetadataSnapshotImpl(const ZooKeeperPtr & zookeeper, const FilterByNameFunction & filter_by_table_name,
|
||||
size_t max_retries, UInt32 & max_log_ptr) const;
|
||||
|
||||
ASTPtr parseQueryFromMetadataInZooKeeper(const String & node_name, const String & query);
|
||||
ASTPtr parseQueryFromMetadataInZooKeeper(const String & node_name, const String & query) const;
|
||||
String readMetadataFile(const String & table_name) const;
|
||||
|
||||
ClusterPtr getClusterImpl(bool all_groups = false) const;
|
||||
@ -132,6 +133,11 @@ private:
|
||||
UInt64 getMetadataHash(const String & table_name) const;
|
||||
bool checkDigestValid(const ContextPtr & local_context, bool debug_check = true) const TSA_REQUIRES(metadata_mutex);
|
||||
|
||||
/// For debug purposes only, don't use in production code
|
||||
void dumpLocalTablesForDebugOnly(const ContextPtr & local_context) const;
|
||||
void dumpTablesInZooKeeperForDebugOnly() const;
|
||||
void tryCompareLocalAndZooKeeperTablesAndDumpDiffForDebugOnly(const ContextPtr & local_context) const;
|
||||
|
||||
void waitDatabaseStarted() const override;
|
||||
void stopLoading() override;
|
||||
|
||||
|
||||
Loading…
Reference in New Issue
Block a user