thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-27 01:51:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Mask secrets in log

Browse Source
This commit is contained in:
kssenii 2022-11-21 22:30:20 +01:00
parent 894b654f93
commit 1073626f8e
3 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Parsers/ASTAlterNamedCollectionQuery.cpp
View File

@ -29,7 +29,10 @@ void ASTAlterNamedCollectionQuery::formatImpl(const IAST::FormatSettings & setti
first = false; first = false;
formatSettingName(change.name, settings.ostr); formatSettingName(change.name, settings.ostr);
settings.ostr << " = " << applyVisitor(FieldVisitorToString(), change.value); if (settings.show_secrets)
settings.ostr << " = " << applyVisitor(FieldVisitorToString(), change.value);
else
settings.ostr << " = '[HIDDEN]'";
} }
} }
if (!delete_keys.empty()) if (!delete_keys.empty())

6
src/Parsers/ASTCreateNamedCollectionQuery.cpp
View File

@ -32,7 +32,11 @@ void ASTCreateNamedCollectionQuery::formatImpl(const IAST::FormatSettings & sett
first = false; first = false;
formatSettingName(change.name, settings.ostr); formatSettingName(change.name, settings.ostr);
settings.ostr << " = " << applyVisitor(FieldVisitorToString(), change.value);
if (settings.show_secrets)
settings.ostr << " = " << applyVisitor(FieldVisitorToString(), change.value);
else
settings.ostr << " = '[HIDDEN]'";
} }
} }

4
src/Storages/NamedCollectionUtils.cpp
View File

@ -25,7 +25,7 @@ namespace DB
namespace ErrorCodes namespace ErrorCodes
{ {
extern const int NAMED_COLLECTION_ALREADY_EXISTS; extern const int NAMED_COLLECTION_ALREADY_EXISTS;
extern const int NAMED_COLLECTION_DOESNT_EXISTS; extern const int NAMED_COLLECTION_DOESNT_EXIST;
extern const int BAD_ARGUMENTS; extern const int BAD_ARGUMENTS;
} }
@ -269,7 +269,7 @@ public:
if (!removeIfExists(collection_name)) if (!removeIfExists(collection_name))
{ {
throw Exception( throw Exception(
ErrorCodes::NAMED_COLLECTION_DOESNT_EXISTS, ErrorCodes::NAMED_COLLECTION_DOESNT_EXIST,
"Cannot remove collection `{}`, because it doesn't exist", "Cannot remove collection `{}`, because it doesn't exist",
collection_name); collection_name);
} }