thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 15:12:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix overflow in mapPopulateSeries

Browse Source
This commit is contained in:
Alexey Milovidov 2021-02-06 23:18:42 +03:00
parent b0f201df72
commit 1209c02869
3 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Functions/array/mapPopulateSeries.cpp
View File

@ -16,6 +16,7 @@ namespace ErrorCodes
extern const int ILLEGAL_COLUMN;
extern const int ILLEGAL_TYPE_OF_ARGUMENT;
extern const int NUMBER_OF_ARGUMENTS_DOESNT_MATCH;
extern const int TOO_LARGE_ARRAY_SIZE;
}
class FunctionMapPopulateSeries : public IFunction
@ -188,9 +189,13 @@ private:
}
}
static constexpr size_t MAX_ARRAY_SIZE = 1ULL << 30;
if (static_cast<size_t>(max_key - min_key) > MAX_ARRAY_SIZE)
throw Exception(ErrorCodes::TOO_LARGE_ARRAY_SIZE, "Too large array size in the result of function {}", getName());
/* fill the result arrays */
KeyType key;
for (key = min_key; key <= max_key; ++key)
for (key = min_key;; ++key)
{
to_keys_data.insert(key);
@ -205,6 +210,8 @@ private:
}
++offset;
if (key == max_key)
break;
}
to_keys_offsets.push_back(offset);

1
tests/queries/0_stateless/01698_map_populate_overflow.reference Normal file
View File

@ -0,0 +1 @@
([18446744073709551615],[0])

2
tests/queries/0_stateless/01698_map_populate_overflow.sql Normal file
View File

@ -0,0 +1,2 @@
SELECT mapPopulateSeries([0xFFFFFFFFFFFFFFFF], [0], 0xFFFFFFFFFFFFFFFF);
SELECT mapPopulateSeries([toUInt64(1)], [1], 0xFFFFFFFFFFFFFFFF); -- { serverError 128 }