thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 08:02:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed test cases of parsing/formatting DateTime64

Browse Source
This commit is contained in:
Vasily Nemkov 2020-03-06 16:31:50 +08:00
parent f281724066
commit 12596256ac
1 changed files with 32 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
dbms/src/IO/tests/gtest_DateTime64_parsing_and_writing.cpp
View File

@ -18,7 +18,7 @@ struct DateTime64StringsTestParam
const std::string_view string;
DateTime64 dt64;
UInt32 scale;
const DateLUTImpl & timezone = DateLUT::instance();
const DateLUTImpl & timezone;
};
static std::ostream & operator << (std::ostream & ostr, const DateTime64StringsTestParam & param)
@ -38,7 +38,7 @@ TEST_P(DateTime64StringParseTest, readDateTime64Text)
ReadBufferFromMemory read_buffer(param.string.data(), param.string.size());
DateTime64 actual;
EXPECT_TRUE(tryReadDateTime64Text(actual, param.scale, read_buffer));
EXPECT_TRUE(tryReadDateTime64Text(actual, param.scale, read_buffer, param.timezone));
EXPECT_EQ(param.dt64, actual);
}
@ -61,7 +61,7 @@ TEST_P(DateTime64StringWriteTest, WriteText)
PaddedPODArray<char> actual_string(param.string.size() * 2, '\0'); // TODO: detect overflows
WriteBuffer write_buffer(actual_string.data(), actual_string.size());
EXPECT_NO_THROW(writeDateTimeText(param.dt64, param.scale, write_buffer));
EXPECT_NO_THROW(writeDateTimeText(param.dt64, param.scale, write_buffer, param.timezone));
EXPECT_STREQ(param.string.data(), actual_string.data());
}
@ -86,49 +86,57 @@ INSTANTIATE_TEST_SUITE_P(Basic,
"When subsecond part is missing from string it is set to zero.",
"2019-09-16 19:20:17",
1568650817'000,
3
3,
DateLUT::instance("Europe/Minsk")
},
{
"When subsecond part is present in string, but it is zero, it is set to zero.",
"2019-09-16 19:20:17.0",
1568650817'000,
3
3,
DateLUT::instance("Europe/Minsk")
},
{
"When scale is 0, subsecond part is not set.",
"2019-09-16 19:20:17",
1568650817ULL,
0
0,
DateLUT::instance("Europe/Minsk")
},
{
"When scale is 0, subsecond part is 0 despite beeing present in string.",
"2019-09-16 19:20:17.123",
1568650817ULL,
0
0,
DateLUT::instance("Europe/Minsk")
},
{
"When subsecond part is present in string, it is set correctly to DateTime64 value of scale 3.",
"2019-09-16 19:20:17.123",
1568650817'123,
3
3,
DateLUT::instance("Europe/Minsk")
},
{
"When subsecond part is present in string (and begins with 0), it is set correctly to DateTime64 value of scale 3.",
"2019-09-16 19:20:17.012",
1568650817'012,
3
3,
DateLUT::instance("Europe/Minsk")
},
{
"When subsecond part scale is smaller than DateTime64 scale, subsecond part is properly adjusted (as if padded from right with zeroes).",
"2019-09-16 19:20:17.123",
1568650817'12300ULL,
5
5,
DateLUT::instance("Europe/Minsk")
},
{
"When subsecond part scale is larger than DateTime64 scale, subsecond part is truncated.",
"2019-09-16 19:20:17.123",
1568650817'1ULL,
1
1,
DateLUT::instance("Europe/Minsk")
}
})
);
@ -137,10 +145,11 @@ INSTANTIATE_TEST_SUITE_P(BestEffort,
DateTime64StringParseBestEffortTest,
::testing::ValuesIn(std::initializer_list<DateTime64StringsTestParam>{
{
"When subsecond part is unreasonably large, it fals to parse",
"When subsecond part is unreasonably large, it truncated to given scale",
"2019-09-16 19:20:17.12345678910111213141516171819202122233435363738393031323334353637383940414243444546474849505152535455565758596061626364",
1568650817'123456ULL,
6
6,
DateLUT::instance("Europe/Minsk")
}
})
);
@ -155,31 +164,36 @@ INSTANTIATE_TEST_SUITE_P(Basic,
"non-zero subsecond part on DateTime64 with scale of 3",
"2019-09-16 19:20:17.123",
1568650817'123,
3
3,
DateLUT::instance("Europe/Minsk")
},
{
"non-zero subsecond part on DateTime64 with scale of 5",
"2019-09-16 19:20:17.12345",
1568650817'12345ULL,
5
5,
DateLUT::instance("Europe/Minsk")
},
{
"Zero subsecond part is written to string",
"2019-09-16 19:20:17.000",
1568650817'000ULL,
3
3,
DateLUT::instance("Europe/Minsk")
},
{
"When scale is 0, subsecond part (and separtor) is missing from string",
"2019-09-16 19:20:17",
1568650817ULL,
0
0,
DateLUT::instance("Europe/Minsk")
},
{
"Subsecond part with leading zeroes is written to string correctly",
"2019-09-16 19:20:17.001",
1568650817'001ULL,
3
3,
DateLUT::instance("Europe/Minsk")
}
})
);