thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-04 13:32:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix

Browse Source 
fix comment
This commit is contained in:
feng lv 2021-12-24 05:19:51 +00:00
parent 80c5bfcbcb
commit 148fbb82ad
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Functions/FunctionsComparison.h
View File

@ -688,7 +688,7 @@ private:
return (res = DecimalComparison<LeftDataType, RightDataType, Op, false>::apply(col_left, col_right)) != nullptr; return (res = DecimalComparison<LeftDataType, RightDataType, Op, false>::apply(col_left, col_right)) != nullptr;
}; };
if (!callOnBasicTypes<true, true, true, true>(left_number, right_number, call)) if (!callOnBasicTypes<true, false, true, true>(left_number, right_number, call))
throw Exception("Wrong call for " + getName() + " with " + col_left.type->getName() + " and " + col_right.type->getName(), throw Exception("Wrong call for " + getName() + " with " + col_left.type->getName() + " and " + col_right.type->getName(),
ErrorCodes::LOGICAL_ERROR); ErrorCodes::LOGICAL_ERROR);
@ -1236,13 +1236,13 @@ public:
} }
else else
{ {
// compare /// Check does another data type is comparable to Decimal, includes Int and Float.
if (!allowDecimalComparison(left_type, right_type) && !date_and_datetime) if (!allowDecimalComparison(left_type, right_type) && !date_and_datetime)
throw Exception( throw Exception(
"No operation " + getName() + " between " + left_type->getName() + " and " + right_type->getName(), "No operation " + getName() + " between " + left_type->getName() + " and " + right_type->getName(),
ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT); ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT);
/// When Decimal comparing to Float32/64, We convert both of them into Float64. Other systems like MySQL /// When Decimal comparing to Float32/64, we convert both of them into Float64.
/// also do as this. /// Other systems like MySQL and Spark also do as this.
if (left_is_float || right_is_float) if (left_is_float || right_is_float)
{ {
const auto converted_type = DataTypeFactory::instance().get("Float64"); const auto converted_type = DataTypeFactory::instance().get("Float64");