thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-03 13:02:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bad cast in arrayIndex #26330

Browse Source
This commit is contained in:
Alexey Milovidov 2021-08-15 09:33:08 +03:00
parent 8a843ae15f
commit 15eb68d117
3 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Functions/array/arrayIndex.h
View File

@ -115,6 +115,13 @@ private:
[[maybe_unused]] const NullMap * const null_map_data,
[[maybe_unused]] const NullMap * const null_map_item)
{
if constexpr (std::is_same_v<Data, IColumn> && std::is_same_v<Target, IColumn>)
{
/// Generic variant is using IColumn::compare function that only allows to compare columns of identical types.
if (typeid(data) != typeid(target))
throw Exception(ErrorCodes::ILLEGAL_COLUMN, "Columns {} and {} cannot be compared", data.getName(), target.getName());
}
const size_t size = offsets.size();
result.resize(size);

0
tests/queries/0_stateless/02010_array_index_bad_cast.reference Normal file
View File

2
tests/queries/0_stateless/02010_array_index_bad_cast.sql Normal file
View File

@ -0,0 +1,2 @@
-- This query throws exception about uncomparable data types (but at least it does not introduce bad cast in code).
SELECT has(materialize(CAST(['2021-07-14'] AS Array(LowCardinality(Nullable(DateTime))))), materialize('2021-07-14'::DateTime64(7))); -- { serverError 44 }