thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-25 00:52:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

review fixes

Browse Source
This commit is contained in:
Vitaly Orlov 2021-10-13 07:33:53 +03:00
parent 4d2b34a7f0
commit 1623bfa1a2
No known key found for this signature in database
GPG Key ID: 58F48CDD37483DA0
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Functions/FunctionsJSON.h
View File

@ -1362,7 +1362,7 @@ public:
static DataTypePtr getReturnType(const char *, const ColumnsWithTypeAndName &)
{
return std::make_unique<DataTypeString>();
return std::make_unique<DataTypeArray>(std::make_shared<DataTypeString>());
}
static size_t getNumberOfIndexArguments(const ColumnsWithTypeAndName & arguments) { return arguments.size() - 1; }
@ -1374,16 +1374,15 @@ public:
auto object = element.getObject();
auto & col_arr = assert_cast<ColumnArray &>(dest);
auto & col_tuple = assert_cast<ColumnTuple &>(col_arr.getData());
auto & col_key = assert_cast<ColumnString &>(col_tuple.getColumn(0));
ColumnArray & col_res = assert_cast<ColumnArray &>(dest);
auto & col_key = assert_cast<ColumnString &>(col_res.getData());
for (const auto & [key, value] : object)
{
col_key.insertData(key.data(), key.size());
}
col_arr.getOffsets().push_back(col_arr.getOffsets().back() + object.size());
col_res.getOffsets().push_back(col_res.getOffsets().back() + object.size());
return true;
}
};