thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

init.d: lock should be released in child process after fork

Browse Source
This commit is contained in:
Pavel Kartavyy 2014-12-29 21:52:50 +03:00
parent d9e9cf6f11
commit 1829949d6e
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tools/init.d/template
View File

@ -121,8 +121,8 @@ start()
for i in $(seq 1 $NUMBER_OF_PROCESSES); do for i in $(seq 1 $NUMBER_OF_PROCESSES); do
if ! is_running $(generate_pid_name $i); then if ! is_running $(generate_pid_name $i); then
rm -f $(generate_pid_name $i) rm -f $(generate_pid_name $i)
# TODO может лучше передавать демону номер процесса, а демон сам будет делать все необходимые подстановки # чтобы лок не удерживался в течении времени жизни дочернего процесса, освободим лок
su -l $USER -s $SHELL -c "exec -a $(generate_program_name $i) \"$BINDIR/$PROGRAM\" --daemon --pid-file=\"$(generate_pid_name $i)\" --config-file=\"$CNFFILE\" $(specific_log_file_for_each_process $i)" su -l $USER -s $SHELL -c "flock -u 9; exec -a $(generate_program_name $i) \"$BINDIR/$PROGRAM\" --daemon --pid-file=\"$(generate_pid_name $i)\" --config-file=\"$CNFFILE\" $(specific_log_file_for_each_process $i)"
EXIT_STATUS=$? EXIT_STATUS=$?
if [[ $EXIT_STATUS -ne 0 ]]; then if [[ $EXIT_STATUS -ne 0 ]]; then
break break
@ -256,6 +256,9 @@ main()
} }
( (
flock -n 9 || echo "Init script is already running" && exit 1 if flock -n 9; then
main main "$@"
else
echo "Init script is already running" && exit 1
fi
) 9> $LOCKFILE ) 9> $LOCKFILE