thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-10 00:12:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix

Browse Source
This commit is contained in:
kssenii 2023-05-03 13:16:08 +02:00
parent d8d0d78db8
commit 189f276ff5
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Disks/IO/ReadBufferFromRemoteFSGather.cpp
View File

@ -107,8 +107,6 @@ IAsynchronousReader::Result ReadBufferFromRemoteFSGather::readInto(char * data,
file_offset_of_buffer_end = offset;
bytes_to_ignore = ignore;
assert(!bytes_to_ignore || initialized());
auto result = nextImpl();
if (result)

8
src/Storages/StorageS3.cpp
View File

@ -669,11 +669,15 @@ std::unique_ptr<ReadBuffer> StorageS3Source::createAsyncS3ReadBuffer(
std::move(read_buffer_creator),
StoredObjects{StoredObject{key, object_size}},
read_settings,
context->getFilesystemCacheLog());
/* cache_log */nullptr);
auto modified_settings{read_settings};
/// FIXME: Changing this setting to default value breaks something around parquet reading
modified_settings.remote_read_min_bytes_for_seek = modified_settings.remote_fs_buffer_size;
auto & pool_reader = context->getThreadPoolReader(FilesystemReaderType::ASYNCHRONOUS_REMOTE_FS_READER);
auto async_reader = std::make_unique<AsynchronousReadIndirectBufferFromRemoteFS>(
pool_reader, read_settings, std::move(s3_impl),
pool_reader, modified_settings, std::move(s3_impl),
context->getAsyncReadCounters(), context->getFilesystemReadPrefetchesLog());
async_reader->setReadUntilEnd();