thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-19 16:20:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

More optimal check for intrsecting parts in DefaultCoordinator init

Browse Source
This commit is contained in:
Alexander Gololobov 2024-09-17 16:54:49 +02:00
parent aba7de5091
commit 190d3f04c9
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/Storages/MergeTree/ParallelReplicasReadingCoordinator.cpp
View File

@ -376,17 +376,20 @@ void DefaultCoordinator::initializeReadingState(InitialAllRangesAnnouncement ann
if (state_initialized) if (state_initialized)
return; return;
for (auto && part : announcement.description)
{ {
auto intersecting_it = std::find_if( /// To speedup search for adjacent parts
all_parts_to_read.begin(), Parts known_parts(all_parts_to_read.begin(), all_parts_to_read.end());
all_parts_to_read.end(),
[&part](const Part & other) { return !other.description.info.isDisjoint(part.info); });
if (intersecting_it != all_parts_to_read.end()) for (auto && part : announcement.description)
throw Exception(ErrorCodes::LOGICAL_ERROR, "Intersecting parts found in announcement"); {
auto intersecting_it = known_parts.lower_bound(Part{.description = part, .replicas = {}});
all_parts_to_read.push_back(Part{.description = std::move(part), .replicas = {announcement.replica_num}}); if (intersecting_it != known_parts.end() && !intersecting_it->description.info.isDisjoint(part.info))
throw Exception(ErrorCodes::LOGICAL_ERROR, "Intersecting parts found in announcement");
all_parts_to_read.push_back(Part{.description = std::move(part), .replicas = {announcement.replica_num}});
known_parts.emplace(Part{.description = part, .replicas = {}});
}
} }
std::ranges::sort( std::ranges::sort(