thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-27 01:51:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disallow const haystack with non-const needle argument

Browse Source
This commit is contained in:
Robert Schulze 2022-07-14 08:02:49 +00:00
parent 6ec4f3cf3d
commit 198abad284
No known key found for this signature in database
GPG Key ID: 26703B55FB13728A
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Functions/FunctionsMultiStringPosition.h
View File

@ -26,6 +26,7 @@ namespace DB
namespace ErrorCodes namespace ErrorCodes
{ {
extern const int ILLEGAL_COLUMN;
extern const int ILLEGAL_TYPE_OF_ARGUMENT; extern const int ILLEGAL_TYPE_OF_ARGUMENT;
} }
@ -64,12 +65,16 @@ public:
const ColumnPtr & needles_ptr = arguments[1].column; const ColumnPtr & needles_ptr = arguments[1].column;
const ColumnString * col_haystack_vector = checkAndGetColumn<ColumnString>(&*haystack_ptr); const ColumnString * col_haystack_vector = checkAndGetColumn<ColumnString>(&*haystack_ptr);
assert(col_haystack_vector); const ColumnConst * col_haystack_const = checkAndGetColumnConst<ColumnString>(&*haystack_ptr);
assert(static_cast<bool>(col_haystack_vector) ^ static_cast<bool>(col_haystack_const));
const ColumnArray * col_needles_vector = checkAndGetColumn<ColumnArray>(needles_ptr.get()); const ColumnArray * col_needles_vector = checkAndGetColumn<ColumnArray>(needles_ptr.get());
const ColumnConst * col_needles_const = checkAndGetColumnConst<ColumnArray>(needles_ptr.get()); const ColumnConst * col_needles_const = checkAndGetColumnConst<ColumnArray>(needles_ptr.get());
assert(static_cast<bool>(col_needles_vector) ^ static_cast<bool>(col_needles_const)); assert(static_cast<bool>(col_needles_vector) ^ static_cast<bool>(col_needles_const));
if (col_haystack_const && col_needles_vector)
throw Exception(ErrorCodes::ILLEGAL_COLUMN, "Function '{}' doesn't support search with non-constant needles in constant haystack", name);
using ResultType = typename Impl::ResultType; using ResultType = typename Impl::ResultType;
auto col_res = ColumnVector<ResultType>::create(); auto col_res = ColumnVector<ResultType>::create();
auto col_offsets = ColumnArray::ColumnOffsets::create(); auto col_offsets = ColumnArray::ColumnOffsets::create();
@ -89,7 +94,9 @@ public:
col_needles_vector->getData(), col_needles_vector->getOffsets(), col_needles_vector->getData(), col_needles_vector->getOffsets(),
vec_res, offsets_res); vec_res, offsets_res);
// TODO: add comment about const const // the combination of const haystack + const needle is not implemented because
// useDefaultImplementationForConstants() == true makes upper layers convert both to
// non-const columns
return ColumnArray::create(std::move(col_res), std::move(col_offsets)); return ColumnArray::create(std::move(col_res), std::move(col_offsets));
} }