Merge pull request #37382 from ClickHouse/wc++98-compat-extra-semi

Enable -Wc++98-compat-extra-semi

src/Client/HedgedConnections.cpp

@@ -345,7 +345,7 @@ HedgedConnections::ReplicaLocation HedgedConnections::getReadyReplicaLocation(As
         else
             throw Exception("Unknown event from epoll", ErrorCodes::LOGICAL_ERROR);
     }
-};
+}
 
 bool HedgedConnections::resumePacketReceiver(const HedgedConnections::ReplicaLocation & location)
 {

src/Common/tests/gtest_lru_file_cache.cpp

@@ -32,7 +32,7 @@ void assertRange(
     ASSERT_EQ(range.left, expected_range.left);
     ASSERT_EQ(range.right, expected_range.right);
     ASSERT_EQ(file_segment->state(), expected_state);
-};
+}
 
 void printRanges(const auto & segments)
 {

src/Common/tests/gtest_sensitive_data_masker.cpp

@@ -22,7 +22,7 @@ extern const int CANNOT_COMPILE_REGEXP;
 extern const int NO_ELEMENTS_IN_CONFIG;
 extern const int INVALID_CONFIG_PARAMETER;
 }
-};
+}
 
 
 TEST(Common, SensitiveDataMasker)

src/Compression/tests/gtest_compressionCodec.cpp

@@ -790,7 +790,7 @@ std::vector<CodecTestSequence> generatePyramidOfSequences(const size_t sequences
     }
 
     return sequences;
-};
+}
 
 // helper macro to produce human-friendly sequence name from generator
 #define G(generator) generator, #generator

src/DataTypes/tests/gtest_data_type_get_common_type.cpp

@@ -22,7 +22,7 @@ static auto typeFromString(const std::string & str)
 {
     auto & data_type_factory = DataTypeFactory::instance();
     return data_type_factory.get(str);
-};
+}
 
 static auto typesFromString(const std::string & str)
 {
@@ -33,7 +33,7 @@ static auto typesFromString(const std::string & str)
         data_types.push_back(typeFromString(data_type));
 
     return data_types;
-};
+}
 
 struct TypesTestCase
 {

src/Disks/IDiskRemote.cpp

@@ -23,7 +23,7 @@ namespace ErrorCodes
     extern const int INCORRECT_DISK_INDEX;
     extern const int UNKNOWN_FORMAT;
     extern const int FILE_ALREADY_EXISTS;
-    extern const int PATH_ACCESS_DENIED;;
+    extern const int PATH_ACCESS_DENIED;
     extern const int FILE_DOESNT_EXIST;
     extern const int BAD_FILE_TYPE;
 }

src/Functions/SubtractSubSeconds.cpp

@@ -9,19 +9,19 @@ using FunctionSubtractNanoseconds = FunctionDateOrDateTimeAddInterval<SubtractNa
 void registerFunctionSubtractNanoseconds(FunctionFactory & factory)
 {
     factory.registerFunction<FunctionSubtractNanoseconds>();
-};
+}
 
 using FunctionSubtractMicroseconds = FunctionDateOrDateTimeAddInterval<SubtractMicrosecondsImpl>;
 void registerFunctionSubtractMicroseconds(FunctionFactory & factory)
 {
     factory.registerFunction<FunctionSubtractMicroseconds>();
-};
+}
 
 using FunctionSubtractMilliseconds = FunctionDateOrDateTimeAddInterval<SubtractMillisecondsImpl>;
 void registerFunctionSubtractMilliseconds(FunctionFactory & factory)
 {
     factory.registerFunction<FunctionSubtractMilliseconds>();
-};
+}
 
 }
 

src/Interpreters/SessionLog.cpp

@@ -61,7 +61,7 @@ void fillColumnArray(const Strings & data, IColumn & column)
     }
     auto & offsets = array.getOffsets();
     offsets.push_back(offsets.back() + size);
-};
+}
 
 }
 

src/Storages/ExecutableSettings.cpp

@@ -14,7 +14,7 @@ namespace ErrorCodes
     extern const int UNKNOWN_SETTING;
 }
 
-IMPLEMENT_SETTINGS_TRAITS(ExecutableSettingsTraits, LIST_OF_EXECUTABLE_SETTINGS);
+IMPLEMENT_SETTINGS_TRAITS(ExecutableSettingsTraits, LIST_OF_EXECUTABLE_SETTINGS)
 
 void ExecutableSettings::loadFromQuery(ASTStorage & storage_def)
 {

src/Storages/IndicesDescription.cpp

@@ -19,7 +19,7 @@ namespace ErrorCodes
 {
     extern const int INCORRECT_QUERY;
     extern const int LOGICAL_ERROR;
-};
+}
 
 IndexDescription::IndexDescription(const IndexDescription & other)
     : definition_ast(other.definition_ast ? other.definition_ast->clone() : nullptr)

src/Storages/MeiliSearch/MeiliSearchColumnDescriptionFetcher.cpp

@@ -84,4 +84,4 @@ ColumnsDescription MeiliSearchColumnDescriptionFetcher::fetchColumnsDescription(
     return ColumnsDescription(list);
 }
 
-};
+}

src/Storages/MeiliSearch/MeiliSearchColumnDescriptionFetcher.h

@@ -21,4 +21,4 @@ private:
     MeiliSearchConnection connection;
 };
 
-};
+}

src/Storages/MergeTree/MergeTreeIndexFullText.cpp

@@ -660,7 +660,7 @@ MergeTreeIndexConditionPtr MergeTreeIndexFullText::createIndexCondition(
         const SelectQueryInfo & query, ContextPtr context) const
 {
     return std::make_shared<MergeTreeConditionFullText>(query, context, index.sample_block, params, token_extractor.get());
-};
+}
 
 bool MergeTreeIndexFullText::mayBenefitFromIndexForIn(const ASTPtr & node) const
 {

src/Storages/MergeTree/MergeTreeIndexSet.cpp

@@ -484,7 +484,7 @@ MergeTreeIndexConditionPtr MergeTreeIndexSet::createIndexCondition(
     const SelectQueryInfo & query, ContextPtr context) const
 {
     return std::make_shared<MergeTreeIndexConditionSet>(index.name, index.sample_block, max_rows, query, context);
-};
+}
 
 bool MergeTreeIndexSet::mayBenefitFromIndexForIn(const ASTPtr &) const
 {

src/Storages/MergeTree/MergeTreeWhereOptimizer.cpp

@@ -123,14 +123,14 @@ static const ASTFunction * getAsTuple(const ASTPtr & node)
     if (const auto * func = node->as<ASTFunction>(); func && func->name == "tuple")
         return func;
     return {};
-};
+}
 
 static bool getAsTupleLiteral(const ASTPtr & node, Tuple & tuple)
 {
     if (const auto * value_tuple = node->as<ASTLiteral>())
         return value_tuple && value_tuple->value.tryGet<Tuple>(tuple);
     return false;
-};
+}
 
 bool MergeTreeWhereOptimizer::tryAnalyzeTuple(Conditions & res, const ASTFunction * func, bool is_final) const
 {

src/Storages/ProjectionsDescription.cpp

@@ -29,7 +29,7 @@ namespace ErrorCodes
     extern const int ILLEGAL_PROJECTION;
     extern const int NOT_IMPLEMENTED;
     extern const int LOGICAL_ERROR;
-};
+}
 
 bool ProjectionDescription::isPrimaryKeyColumnPossiblyWrappedInFunctions(const ASTPtr & node) const
 {