fixes

src/Common/ZooKeeper/TestKeeper.cpp

@@ -213,10 +213,11 @@ std::pair<ResponsePtr, Undo> TestKeeperCreateRequest::process(TestKeeper::Contai
             created_node.is_sequental = is_sequential;
             std::string path_created = path;
 
+            ++it->second.seq_num;
+
             if (is_sequential)
             {
                 auto seq_num = it->second.seq_num;
-                ++it->second.seq_num;
 
                 std::stringstream seq_num_str;      // STYLE_CHECK_ALLOW_STD_STRING_STREAM
                 seq_num_str.exceptions(std::ios::failbit);
@@ -228,14 +229,13 @@ std::pair<ResponsePtr, Undo> TestKeeperCreateRequest::process(TestKeeper::Contai
             response.path_created = path_created;
             container.emplace(path_created, std::move(created_node));
 
-            undo = [&container, path_created, is_sequential = is_sequential, parent_path = it->first]
+            undo = [&container, path_created, parent_path = it->first]
             {
                 container.erase(path_created);
                 auto & undo_parent = container.at(parent_path);
                 --undo_parent.stat.cversion;
                 --undo_parent.stat.numChildren;
 
-                if (is_sequential)
                 --undo_parent.seq_num;
             };
 

src/Databases/DatabaseReplicated.cpp

@@ -170,6 +170,7 @@ void DatabaseReplicated::loadStoredObjects(Context & context, bool has_force_res
     DatabaseAtomic::loadStoredObjects(context, has_force_restore_data_flag, force_attach);
 
     ddl_worker = std::make_unique<DatabaseReplicatedDDLWorker>(this, global_context);
+    ddl_worker->startup();
 }
 
 void DatabaseReplicated::onUnexpectedLogEntry(const String & entry_name, const ZooKeeperPtr & zookeeper)

src/Interpreters/Context.cpp

@@ -1487,6 +1487,7 @@ void Context::setDDLWorker(std::unique_ptr<DDLWorker> ddl_worker)
     auto lock = getLock();
     if (shared->ddl_worker)
         throw Exception("DDL background thread has already been initialized", ErrorCodes::LOGICAL_ERROR);
+    ddl_worker->startup();
     shared->ddl_worker = std::move(ddl_worker);
 }
 

src/Interpreters/DDLWorker.cpp

@@ -167,7 +167,10 @@ DDLWorker::DDLWorker(int pool_size_, const std::string & zk_root_dir, const Cont
 
     host_fqdn = getFQDNOrHostName();
     host_fqdn_id = Cluster::Address::toString(host_fqdn, context.getTCPPort());
+}
 
+void DDLWorker::startup()
+{
     main_thread = ThreadFromGlobalPool(&DDLWorker::runMainThread, this);
     cleanup_thread = ThreadFromGlobalPool(&DDLWorker::runCleanupThread, this);
 }
@@ -183,7 +186,9 @@ DDLWorker::~DDLWorker()
 {
     shutdown();
     worker_pool.wait();
+    if (main_thread.joinable())
         main_thread.join();
+    if (cleanup_thread.joinable())
         cleanup_thread.join();
 }
 
@@ -421,7 +426,12 @@ void DDLWorker::enqueueTask(DDLTaskPtr task_ptr)
             else if (e.code == Coordination::Error::ZNONODE)
             {
                 LOG_ERROR(log, "ZooKeeper error: {}", getCurrentExceptionMessage(true));
-                // TODO: retry?
+                if (!current_zookeeper->exists(task_ptr->entry_path))
+                {
+                    //FIXME race condition with cleanup thread
+                    LOG_ERROR(log, "Task {} is lost. It probably was removed by other server.", task_ptr->entry_path);
+                    return;
+                }
             }
             else
             {

src/Interpreters/DDLWorker.h

@@ -51,6 +51,7 @@ public:
         return host_fqdn_id;
     }
 
+    void startup();
     void shutdown();
 
     bool isCurrentlyActive() const { return initialized && !stop_flag; }

src/Interpreters/InterpreterCreateQuery.cpp

@@ -136,6 +136,9 @@ BlockIO InterpreterCreateQuery::createDatabase(ASTCreateQuery & create)
         engine->name = "Atomic";
         if (old_style_database)
         {
+            if (database_name == "test")
+                engine->name = "Ordinary";      // for stateful tests
+            else
                 engine = makeASTFunction("Replicated",
                                      std::make_shared<ASTLiteral>(fmt::format("/clickhouse/db/{}/", create.database)),
                                      std::make_shared<ASTLiteral>("s1"),

src/Interpreters/executeDDLQueryOnCluster.cpp

@@ -201,6 +201,10 @@ DDLQueryStatusInputStream::DDLQueryStatusInputStream(const String & zk_node_path
     addTotalRowsApprox(waiting_hosts.size());
 
     timeout_seconds = context.getSettingsRef().distributed_ddl_task_timeout;
+
+    //FIXME revert it before merge
+    if (context.getSettingsRef().default_database_engine.value == DefaultDatabaseEngine::Ordinary)
+        timeout_seconds = 10;
 }
 
 Block DDLQueryStatusInputStream::readImpl()