thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-21 01:00:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #35941 from ClickHouse/revert-35184-clang-tidy-issues

Browse Source 
Revert "clang-tidy report issues with Medium priority"
This commit is contained in:
Alexey Milovidov 2022-04-04 23:42:21 +03:00 committed by GitHub
commit 1b562923f9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/IO/ReadBufferFromFileDescriptor.h
View File

@ -39,10 +39,6 @@ public:
{
}
virtual ~ReadBufferFromFileDescriptor() override
{
}
int getFD() const
{
return fd;
@ -84,9 +80,6 @@ public:
{
use_pread = true;
}
virtual ~ReadBufferFromFileDescriptorPRead() override
{
}
};
}

2
src/Interpreters/SystemLog.cpp
View File

@ -379,7 +379,7 @@ void SystemLog<LogElement>::flushImpl(const std::vector<LogElement> & to_flush,
for (const auto & name_and_type : log_element_names_and_types)
log_element_columns.emplace_back(name_and_type.type, name_and_type.name);
Block block(log_element_columns);
Block block(std::move(log_element_columns));
MutableColumns columns = block.mutateColumns();
for (const auto & elem : to_flush)

2
src/Storages/ColumnsDescription.cpp
View File

@ -122,7 +122,7 @@ void ColumnDescription::readText(ReadBuffer & buf)
if (col_ast->default_expression)
{
default_desc.kind = columnDefaultKindFromString(col_ast->default_specifier);
default_desc.expression = col_ast->default_expression;
default_desc.expression = std::move(col_ast->default_expression);
}
if (col_ast->comment)

2
src/Storages/StorageDistributed.h
View File

@ -44,7 +44,7 @@ class StorageDistributed final : public shared_ptr_helper<StorageDistributed>, p
friend class StorageSystemDistributionQueue;
public:
virtual ~StorageDistributed() override;
~StorageDistributed() override;
std::string getName() const override { return "Distributed"; }