thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-25 03:00:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup

Browse Source
This commit is contained in:
Alexander Kuzmenkov 2021-02-04 09:51:46 +03:00
parent 773b364fe4
commit 1b6262f874
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Parsers/ExpressionElementParsers.cpp
View File

@ -585,7 +585,7 @@ static bool tryParseFrameDefinition(ASTWindowDefinition * node, IParser::Pos & p
if (keyword_preceding.ignore(pos, expected)) if (keyword_preceding.ignore(pos, expected))
{ {
node->frame.begin_offset = - node->frame.begin_offset; node->frame.begin_offset = -node->frame.begin_offset;
} }
else if (keyword_following.ignore(pos, expected)) else if (keyword_following.ignore(pos, expected))
{ {

7
src/Processors/Transforms/WindowTransform.cpp
View File

@ -434,18 +434,15 @@ void WindowTransform::advanceFrameEndCurrentRow()
// fmt::print(stderr, "first row {} last {}\n", frame_end.row, rows_end); // fmt::print(stderr, "first row {} last {}\n", frame_end.row, rows_end);
// We could retreat the frame_end here, but for some reason I am reluctant // Advance frame_end while it is still peers with the current row.
// to do this... It would have better data locality.
auto reference = current_row;
for (; frame_end.row < rows_end; ++frame_end.row) for (; frame_end.row < rows_end; ++frame_end.row)
{ {
if (!arePeers(reference, frame_end)) if (!arePeers(current_row, frame_end))
{ {
// fmt::print(stderr, "{} and {} don't match\n", reference, frame_end); // fmt::print(stderr, "{} and {} don't match\n", reference, frame_end);
frame_ended = true; frame_ended = true;
return; return;
} }
reference = frame_end;
} }
// Might have gotten to the end of the current block, have to properly // Might have gotten to the end of the current block, have to properly