thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-22 07:31:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

added perftest, fixed style check and PVS bugs

Browse Source
This commit is contained in:
myrrc 2020-07-22 22:44:11 +03:00
parent 222eb7fba3
commit 1d0bf93444
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
base/common/StringRef.h
View File

@ -46,7 +46,8 @@ struct StringRef
};
/// Holds {nullptr, 0};
constexpr const StringRef EMPTY_STRING_REF{};
/// Here constexpr doesn't implicate inline, see https://www.viva64.com/en/w/v1043/
constexpr const inline StringRef EMPTY_STRING_REF{};
using StringRefs = std::vector<StringRef>;

1
src/Columns/ColumnNullable.cpp
View File

@ -14,7 +14,6 @@ namespace DB
namespace ErrorCodes
{
extern const int NOT_IMPLEMENTED;
extern const int LOGICAL_ERROR;
extern const int ILLEGAL_COLUMN;
extern const int SIZES_OF_NESTED_COLUMNS_ARE_INCONSISTENT;

5
src/Functions/array/arrayIndex.h
View File

@ -844,6 +844,9 @@ private:
return false;
auto col_res = ResultColumnType::create();
/// Pre-filling is needed as the ArrayIndexNumImpl and ArrayIndexNumNullImpl won't fill the not-found values
/// with 0.
col_res->getData().resize_fill(col_array->getOffsets().size());
const auto [null_map_data, null_map_item] = getNullMaps(block, arguments);
@ -885,7 +888,7 @@ private:
>::vector(
col_array_nested_lc->getIndexes(), /* data -- indices column */
col_array->getOffsets(),
*value_index /* target value to search */ ,
*value_index, /* target value to search */
col_res->getData(),
null_map_data,
null_map_item);