thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 00:22:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #24469 from kitaisreal/function-then-typos

Browse Source 
Fixed IFunction then typos
This commit is contained in:
Maksim Kita 2021-05-25 02:07:31 +03:00 committed by GitHub
commit 1e656bbba5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Functions/IFunction.h
View File

@ -155,7 +155,7 @@ public:
*/ */
virtual bool isSuitableForConstantFolding() const { return true; } virtual bool isSuitableForConstantFolding() const { return true; }
/** If function isSuitableForConstantFolding than, this method will be called during query analyzis /** If function isSuitableForConstantFolding then, this method will be called during query analyzis
* if some arguments are constants. For example logical functions (AndFunction, OrFunction) can * if some arguments are constants. For example logical functions (AndFunction, OrFunction) can
* return they result based on some constant arguments. * return they result based on some constant arguments.
* Arguments are passed without modifications, useDefaultImplementationForNulls, useDefaultImplementationForConstants, * Arguments are passed without modifications, useDefaultImplementationForNulls, useDefaultImplementationForConstants,
@ -301,7 +301,7 @@ protected:
return getReturnTypeImpl(data_types); return getReturnTypeImpl(data_types);
} }
/** If useDefaultImplementationForNulls() is true, than change arguments for getReturnType() and build(): /** If useDefaultImplementationForNulls() is true, then change arguments for getReturnType() and build():
* if some of arguments are Nullable(Nothing) then don't call getReturnType(), call build() with return_type = Nullable(Nothing), * if some of arguments are Nullable(Nothing) then don't call getReturnType(), call build() with return_type = Nullable(Nothing),
* if some of arguments are Nullable, then: * if some of arguments are Nullable, then:
* - Nullable types are substituted with nested types for getReturnType() function * - Nullable types are substituted with nested types for getReturnType() function
@ -311,7 +311,7 @@ protected:
*/ */
virtual bool useDefaultImplementationForNulls() const { return true; } virtual bool useDefaultImplementationForNulls() const { return true; }
/** If useDefaultImplementationForNulls() is true, than change arguments for getReturnType() and build(). /** If useDefaultImplementationForNulls() is true, then change arguments for getReturnType() and build().
* If function arguments has low cardinality types, convert them to ordinary types. * If function arguments has low cardinality types, convert them to ordinary types.
* getReturnType returns ColumnLowCardinality if at least one argument type is ColumnLowCardinality. * getReturnType returns ColumnLowCardinality if at least one argument type is ColumnLowCardinality.
*/ */