thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-29 13:10:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Style AggregateFunctionTopK.cpp

Browse Source
This commit is contained in:
vdimir 2021-12-17 18:04:59 +03:00
parent 5c487b3bdc
commit 1eb032ac83
No known key found for this signature in database
GPG Key ID: 9B404D301C0CC7EB
1 changed files with 14 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/AggregateFunctions/AggregateFunctionTopK.cpp
View File

@ -7,11 +7,12 @@
#include <DataTypes/DataTypeDateTime.h> #include <DataTypes/DataTypeDateTime.h>
#define TOP_K_MAX_SIZE 0xFFFFFF constexpr UInt64 TOP_K_MAX_SIZE = 0xFFFFFF;
namespace DB namespace DB
{ {
struct Settings; struct Settings;
namespace ErrorCodes namespace ErrorCodes
@ -82,28 +83,26 @@ AggregateFunctionPtr createAggregateFunctionTopK(const std::string & name, const
if (!params.empty()) if (!params.empty())
{ {
if (params.size() > 2) if (params.size() > 2)
throw Exception("Aggregate function " + name + " requires two parameters or less.", throw Exception(ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH,
ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH); "Aggregate function '{}' requires two parameters or less", name);
UInt64 k = applyVisitor(FieldVisitorConvertToNumber<UInt64>(), params[0]);
if (params.size() == 2) if (params.size() == 2)
{ {
load_factor = applyVisitor(FieldVisitorConvertToNumber<UInt64>(), params[1]); load_factor = applyVisitor(FieldVisitorConvertToNumber<UInt64>(), params[1]);
if (load_factor < 1) if (load_factor < 1)
throw Exception("Too small parameter 'load_factor' for aggregate function " + name + ". Minimum: 1", throw Exception(ErrorCodes::ARGUMENT_OUT_OF_BOUND,
ErrorCodes::ARGUMENT_OUT_OF_BOUND); "Too small parameter 'load_factor' for aggregate function '{}' (got {}, minimum is 1)", name, load_factor);
} }
if (k > TOP_K_MAX_SIZE || load_factor > TOP_K_MAX_SIZE || k * load_factor > TOP_K_MAX_SIZE) threshold = applyVisitor(FieldVisitorConvertToNumber<UInt64>(), params[0]);
throw Exception("Too large parameter(s) for aggregate function " + name + ". Maximum: " + toString(TOP_K_MAX_SIZE),
ErrorCodes::ARGUMENT_OUT_OF_BOUND);
if (k == 0) if (threshold > TOP_K_MAX_SIZE || load_factor > TOP_K_MAX_SIZE || threshold * load_factor > TOP_K_MAX_SIZE)
throw Exception("Parameter 0 is illegal for aggregate function " + name, throw Exception(ErrorCodes::ARGUMENT_OUT_OF_BOUND,
ErrorCodes::ARGUMENT_OUT_OF_BOUND); "Too large parameter(s) for aggregate function '{}' (maximum is {})", name, toString(TOP_K_MAX_SIZE));
threshold = k; if (threshold == 0)
throw Exception(ErrorCodes::ARGUMENT_OUT_OF_BOUND, "Parameter 0 is illegal for aggregate function '{}'", name);
} }
AggregateFunctionPtr res(createWithNumericType<AggregateFunctionTopK, is_weighted>( AggregateFunctionPtr res(createWithNumericType<AggregateFunctionTopK, is_weighted>(
@ -113,9 +112,8 @@ AggregateFunctionPtr createAggregateFunctionTopK(const std::string & name, const
res = AggregateFunctionPtr(createWithExtraTypes<is_weighted>(argument_types, threshold, load_factor, params)); res = AggregateFunctionPtr(createWithExtraTypes<is_weighted>(argument_types, threshold, load_factor, params));
if (!res) if (!res)
throw Exception("Illegal type " + argument_types[0]->getName() + throw Exception(ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT,
" of argument for aggregate function " + name, ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT); "Illegal type {} of argument for aggregate function '{}'", argument_types[0]->getName(), name);
return res; return res;
} }