From 1f49acc164d7e3fa195e5b593e6aea4ba728a568 Mon Sep 17 00:00:00 2001
From: avogar <avogar@clickhouse.com>
Date: Mon, 24 Jan 2022 16:27:04 +0300
Subject: [PATCH] Better naming

---
 src/Formats/FormatFactory.cpp                            | 2 +-
 src/Formats/FormatFactory.h                              | 2 +-
 src/Processors/Formats/Impl/ArrowBlockOutputFormat.cpp   | 4 ++--
 src/Processors/Formats/Impl/AvroRowOutputFormat.cpp      | 2 +-
 src/Processors/Formats/Impl/JSONRowOutputFormat.cpp      | 4 ++--
 src/Processors/Formats/Impl/ORCBlockOutputFormat.cpp     | 2 +-
 src/Processors/Formats/Impl/ParquetBlockOutputFormat.cpp | 2 +-
 src/Processors/Formats/Impl/XMLRowOutputFormat.cpp       | 2 +-
 8 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/Formats/FormatFactory.cpp b/src/Formats/FormatFactory.cpp
index d0425bd79f8..3f220cbb20a 100644
--- a/src/Formats/FormatFactory.cpp
+++ b/src/Formats/FormatFactory.cpp
@@ -402,7 +402,7 @@ void FormatFactory::registerAppendSupportChecker(const String & name, AppendSupp
     target = std::move(append_support_checker);
 }
 
-void FormatFactory::markFormatDoesntSupportAppend(const String & name)
+void FormatFactory::markFormatHasNoAppendSupport(const String & name)
 {
     registerAppendSupportChecker(name, [](const FormatSettings &){ return false; });
 }
diff --git a/src/Formats/FormatFactory.h b/src/Formats/FormatFactory.h
index 3eb99349ce8..228d5234959 100644
--- a/src/Formats/FormatFactory.h
+++ b/src/Formats/FormatFactory.h
@@ -176,7 +176,7 @@ public:
 
     /// If format always doesn't support append, you can use this method instead of
     /// registerAppendSupportChecker with append_support_checker that always returns true.
-    void markFormatDoesntSupportAppend(const String & name);
+    void markFormatHasNoAppendSupport(const String & name);
 
     bool checkIfFormatSupportAppend(const String & name, ContextPtr context, const std::optional<FormatSettings> & format_settings_ = std::nullopt);
 
diff --git a/src/Processors/Formats/Impl/ArrowBlockOutputFormat.cpp b/src/Processors/Formats/Impl/ArrowBlockOutputFormat.cpp
index c87191d0a12..60408f13ff0 100644
--- a/src/Processors/Formats/Impl/ArrowBlockOutputFormat.cpp
+++ b/src/Processors/Formats/Impl/ArrowBlockOutputFormat.cpp
@@ -93,7 +93,7 @@ void registerOutputFormatArrow(FormatFactory & factory)
         {
             return std::make_shared<ArrowBlockOutputFormat>(buf, sample, false, format_settings);
         });
-    factory.markFormatDoesntSupportAppend("Arrow");
+    factory.markFormatHasNoAppendSupport("Arrow");
 
     factory.registerOutputFormat(
         "ArrowStream",
@@ -104,7 +104,7 @@ void registerOutputFormatArrow(FormatFactory & factory)
         {
             return std::make_shared<ArrowBlockOutputFormat>(buf, sample, true, format_settings);
         });
-    factory.markFormatDoesntSupportAppend("ArrowStream");
+    factory.markFormatHasNoAppendSupport("ArrowStream");
 }
 
 }
diff --git a/src/Processors/Formats/Impl/AvroRowOutputFormat.cpp b/src/Processors/Formats/Impl/AvroRowOutputFormat.cpp
index ae5ce6099a9..70373480920 100644
--- a/src/Processors/Formats/Impl/AvroRowOutputFormat.cpp
+++ b/src/Processors/Formats/Impl/AvroRowOutputFormat.cpp
@@ -479,7 +479,7 @@ void registerOutputFormatAvro(FormatFactory & factory)
     {
         return std::make_shared<AvroRowOutputFormat>(buf, sample, params, settings);
     });
-    factory.markFormatDoesntSupportAppend("Avro");
+    factory.markFormatHasNoAppendSupport("Avro");
 }
 
 }
diff --git a/src/Processors/Formats/Impl/JSONRowOutputFormat.cpp b/src/Processors/Formats/Impl/JSONRowOutputFormat.cpp
index 7ac7d45d26d..8130b2b4cb1 100644
--- a/src/Processors/Formats/Impl/JSONRowOutputFormat.cpp
+++ b/src/Processors/Formats/Impl/JSONRowOutputFormat.cpp
@@ -284,7 +284,7 @@ void registerOutputFormatJSON(FormatFactory & factory)
     });
 
     factory.markOutputFormatSupportsParallelFormatting("JSON");
-    factory.markFormatDoesntSupportAppend("JSON");
+    factory.markFormatHasNoAppendSupport("JSON");
 
     factory.registerOutputFormat("JSONStrings", [](
         WriteBuffer & buf,
@@ -296,7 +296,7 @@ void registerOutputFormatJSON(FormatFactory & factory)
     });
 
     factory.markOutputFormatSupportsParallelFormatting("JSONStrings");
-    factory.markFormatDoesntSupportAppend("JSONStrings");
+    factory.markFormatHasNoAppendSupport("JSONStrings");
 }
 
 }
diff --git a/src/Processors/Formats/Impl/ORCBlockOutputFormat.cpp b/src/Processors/Formats/Impl/ORCBlockOutputFormat.cpp
index 67287c8a661..106b71a9df5 100644
--- a/src/Processors/Formats/Impl/ORCBlockOutputFormat.cpp
+++ b/src/Processors/Formats/Impl/ORCBlockOutputFormat.cpp
@@ -526,7 +526,7 @@ void registerOutputFormatORC(FormatFactory & factory)
     {
         return std::make_shared<ORCBlockOutputFormat>(buf, sample, format_settings);
     });
-    factory.markFormatDoesntSupportAppend("ORC");
+    factory.markFormatHasNoAppendSupport("ORC");
 }
 
 }
diff --git a/src/Processors/Formats/Impl/ParquetBlockOutputFormat.cpp b/src/Processors/Formats/Impl/ParquetBlockOutputFormat.cpp
index c3ddc632641..68e2ae1c6eb 100644
--- a/src/Processors/Formats/Impl/ParquetBlockOutputFormat.cpp
+++ b/src/Processors/Formats/Impl/ParquetBlockOutputFormat.cpp
@@ -85,7 +85,7 @@ void registerOutputFormatParquet(FormatFactory & factory)
         {
             return std::make_shared<ParquetBlockOutputFormat>(buf, sample, format_settings);
         });
-    factory.markFormatDoesntSupportAppend("Parquet");
+    factory.markFormatHasNoAppendSupport("Parquet");
 }
 
 }
diff --git a/src/Processors/Formats/Impl/XMLRowOutputFormat.cpp b/src/Processors/Formats/Impl/XMLRowOutputFormat.cpp
index 6a80131a65e..cc2b37189f9 100644
--- a/src/Processors/Formats/Impl/XMLRowOutputFormat.cpp
+++ b/src/Processors/Formats/Impl/XMLRowOutputFormat.cpp
@@ -256,7 +256,7 @@ void registerOutputFormatXML(FormatFactory & factory)
     });
 
     factory.markOutputFormatSupportsParallelFormatting("XML");
-    factory.markFormatDoesntSupportAppend("XML");
+    factory.markFormatHasNoAppendSupport("XML");
 }
 
 }