thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-22 23:52:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

skip rocksdb test in fasttest

Browse Source
This commit is contained in:
sundy-li 2020-10-01 22:14:52 +08:00
parent df9a003cf7
commit 1f4a63b6c6
3 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docker/test/fasttest/run.sh
View File

@ -270,6 +270,9 @@ TESTS_TO_SKIP=(
00646_url_engine
00974_query_profiler
# Rocksdb is not enabled by default
01504_rocksdb
# Look at DistributedFilesToInsert, so cannot run in parallel.
01460_DistributedFilesToInsert

20
src/Storages/Rocksdb/StorageEmbeddedRocksdb.cpp
View File

@ -225,12 +225,12 @@ Pipe StorageEmbeddedRocksdb::read(
ReadBufferFromString key_buffer(it->key());
ReadBufferFromString value_buffer(it->value());
for (const auto & item : ext::enumerate(sample_block.getColumnsWithTypeAndName()))
for (const auto [idx, column_type] : ext::enumerate(sample_block.getColumnsWithTypeAndName()))
{
if (item.second.name == primary_key)
item.second.type->deserializeBinary(*columns[item.first], key_buffer);
if (column_type.name == primary_key)
column_type.type->deserializeBinary(*columns[idx], key_buffer);
else
item.second.type->deserializeBinary(*columns[item.first], value_buffer);
column_type.type->deserializeBinary(*columns[idx], value_buffer);
}
}
assert(it->status().ok());
@ -258,12 +258,12 @@ Pipe StorageEmbeddedRocksdb::read(
ReadBufferFromString key_buffer(slices_keys[i]);
ReadBufferFromString value_buffer(values[i]);
for (const auto & item : ext::enumerate(sample_block.getColumnsWithTypeAndName()))
for (const auto [idx, column_type] : ext::enumerate(sample_block.getColumnsWithTypeAndName()))
{
if (item.second.name == primary_key)
item.second.type->deserializeBinary(*columns[item.first], key_buffer);
if (column_type.name == primary_key)
column_type.type->deserializeBinary(*columns[idx], key_buffer);
else
item.second.type->deserializeBinary(*columns[item.first], value_buffer);
column_type.type->deserializeBinary(*columns[idx], value_buffer);
}
}
}
@ -279,10 +279,6 @@ BlockOutputStreamPtr StorageEmbeddedRocksdb::write(const ASTPtr & /*query*/, con
return std::make_shared<EmbeddedRocksdbBlockOutputStream>(*this, metadata_snapshot);
}
StorageEmbeddedRocksdb::~StorageEmbeddedRocksdb()
{
}
static StoragePtr create(const StorageFactory::Arguments & args)
{

2
src/Storages/Rocksdb/StorageEmbeddedRocksdb.h
View File

@ -22,8 +22,6 @@ class StorageEmbeddedRocksdb final : public ext::shared_ptr_helper<StorageEmbedd
public:
std::string getName() const override { return "EmbeddedRocksdb"; }
~StorageEmbeddedRocksdb() override;
Pipe read(
const Names & column_names,
const StorageMetadataPtr & metadata_snapshot,