thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-28 02:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed toDateTime64 bug

Browse Source 
Of unable to deduce timezone in function execution phase.
This commit is contained in:
Vasily Nemkov 2019-11-03 08:10:11 +03:00
parent 947cfa6056
commit 1fc28c08e6
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dbms/src/Functions/FunctionsConversion.h
View File

@ -561,7 +561,13 @@ struct ConvertThroughParsing
/// For conversion to DateTime type, second argument with time zone could be specified.
if constexpr (std::is_same_v<ToDataType, DataTypeDateTime> || std::is_same_v<ToDataType, DataTypeDateTime64>)
{
local_time_zone = &extractTimeZoneFromFunctionArguments(block, arguments, 1, 0);
// Time zone is already figured out during result type resultion, no need to do it here.
if (const auto dt_col = checkAndGetDataType<ToDataType>(block.getByPosition(result).type.get()))
local_time_zone = &dt_col->getTimeZone();
else
{
throw Exception("Can't get timezone info from result type", ErrorCodes::ILLEGAL_COLUMN);
}
if constexpr (parsing_mode == ConvertFromStringParsingMode::BestEffort)
utc_time_zone = &DateLUT::instance("UTC");