thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-11 17:02:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle exception in finalize inside WriteBufferFromPocoSocket destructor

Browse Source
This commit is contained in:
Kruglov Pavel 2023-05-11 14:16:48 +02:00 committed by GitHub
parent 57b8e74cea
commit 20007504a7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/IO/WriteBufferFromPocoSocket.cpp
View File

@ -106,7 +106,22 @@ WriteBufferFromPocoSocket::WriteBufferFromPocoSocket(Poco::Net::Socket & socket_
WriteBufferFromPocoSocket::~WriteBufferFromPocoSocket()
{
finalize();
#ifndef NDEBUG
if (!finalized)
{
LOG_ERROR(log, "WriteBufferFromPocoSocket is not finalized in destructor. It's a bug");
std::terminate();
}
#else
try
{
finalize();
}
catch (...)
{
tryLogCurrentException(__PRETTY_FUNCTION__);
}
#endif
}
}