From 2017ee72c923dd081aee7230e7c340b87c614f45 Mon Sep 17 00:00:00 2001 From: Alexey Milovidov Date: Fri, 13 Feb 2015 07:08:25 +0300 Subject: [PATCH] Revert "dbms: improving performance of String IN (set) (for graphite) [#METR-2944]." This reverts commit 504894305d02e73c471e0020057d4b7a96afca1d. --- dbms/src/Interpreters/Set.cpp | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/dbms/src/Interpreters/Set.cpp b/dbms/src/Interpreters/Set.cpp index ff3f1b05a90..a81dd590fa1 100644 --- a/dbms/src/Interpreters/Set.cpp +++ b/dbms/src/Interpreters/Set.cpp @@ -472,23 +472,12 @@ void Set::executeOrdinary(const ConstColumnPlainPtrs & key_columns, ColumnUInt8: const ColumnString::Offsets_t & offsets = column_string->getOffsets(); const ColumnString::Chars_t & data = column_string->getChars(); - StringRef prev_key; - bool prev_result; - /// Для всех строчек for (size_t i = 0; i < rows; ++i) { /// Строим ключ StringRef ref(&data[i == 0 ? 0 : offsets[i - 1]], (i == 0 ? offsets[i] : (offsets[i] - offsets[i - 1])) - 1); - - if (i != 0 && ref == prev_key) - vec_res[i] = prev_result; - else - { - prev_result = negative ^ (set.end() != set.find(ref)); - prev_key = ref; - vec_res[i] = prev_result; - } + vec_res[i] = negative ^ (set.end() != set.find(ref)); } } else if (const ColumnFixedString * column_string = typeid_cast(&column))