thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-29 13:10:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

unexpected behaviour for avg over empty decimal column without group by

Browse Source
This commit is contained in:
akonyaev 2019-10-17 16:08:04 +03:00
parent e595df05d9
commit 22429a699e
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dbms/src/AggregateFunctions/AggregateFunctionAvg.h
View File

@ -27,12 +27,8 @@ struct AggregateFunctionAvgData
template <typename ResultT> template <typename ResultT>
ResultT NO_SANITIZE_UNDEFINED result() const ResultT NO_SANITIZE_UNDEFINED result() const
{ {
if constexpr (std::is_floating_point_v<ResultT>) if (count == 0)
if constexpr (std::numeric_limits<ResultT>::is_iec559) return 0;
return static_cast<ResultT>(sum) / count; /// allow division by zero
if (!count)
throw Exception("AggregateFunctionAvg with zero values", ErrorCodes::LOGICAL_ERROR);
return static_cast<ResultT>(sum) / count; return static_cast<ResultT>(sum) / count;
} }
}; };