mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-09-29 05:00:47 +00:00
unexpected behaviour for avg over empty decimal column without group by
This commit is contained in:
parent
e595df05d9
commit
22429a699e
@ -27,12 +27,8 @@ struct AggregateFunctionAvgData
|
|||||||
template <typename ResultT>
|
template <typename ResultT>
|
||||||
ResultT NO_SANITIZE_UNDEFINED result() const
|
ResultT NO_SANITIZE_UNDEFINED result() const
|
||||||
{
|
{
|
||||||
if constexpr (std::is_floating_point_v<ResultT>)
|
if (count == 0)
|
||||||
if constexpr (std::numeric_limits<ResultT>::is_iec559)
|
return 0;
|
||||||
return static_cast<ResultT>(sum) / count; /// allow division by zero
|
|
||||||
|
|
||||||
if (!count)
|
|
||||||
throw Exception("AggregateFunctionAvg with zero values", ErrorCodes::LOGICAL_ERROR);
|
|
||||||
return static_cast<ResultT>(sum) / count;
|
return static_cast<ResultT>(sum) / count;
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
Loading…
Reference in New Issue
Block a user